You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by zh...@apache.org on 2023/07/13 02:01:21 UTC

[incubator-celeborn] branch main updated: [CELEBORN-790][FOLLOWUP] Use allocator.compositeDirectBuffer to track memory leak

This is an automated email from the ASF dual-hosted git repository.

zhouky pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 03717375f [CELEBORN-790][FOLLOWUP] Use allocator.compositeDirectBuffer to track memory leak
03717375f is described below

commit 03717375fc4fde88d4d3c117a68de45289aba69b
Author: zky.zhoukeyong <zk...@alibaba-inc.com>
AuthorDate: Thu Jul 13 10:01:11 2023 +0800

    [CELEBORN-790][FOLLOWUP] Use allocator.compositeDirectBuffer to track memory leak
    
    ### What changes were proposed in this pull request?
    According to https://github.com/apache/incubator-celeborn/pull/1709#discussion_r1260133078
    
    ### Why are the changes needed?
    ditto
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Passes GA.
    
    Closes #1711 from waitinfuture/790-fu.
    
    Authored-by: zky.zhoukeyong <zk...@alibaba-inc.com>
    Signed-off-by: zky.zhoukeyong <zk...@alibaba-inc.com>
---
 .../org/apache/celeborn/service/deploy/worker/storage/Flusher.scala     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/Flusher.scala b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/Flusher.scala
index c86ac1724..3b615227f 100644
--- a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/Flusher.scala
+++ b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/Flusher.scala
@@ -105,7 +105,7 @@ abstract private[worker] class Flusher(
   def takeBuffer(): CompositeByteBuf = {
     var buffer = bufferQueue.poll()
     if (buffer == null) {
-      buffer = new CompositeByteBuf(allocator, true, maxComponents)
+      buffer = allocator.compositeDirectBuffer(maxComponents)
     }
     buffer
   }