[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #9295: [Frontend][PaddlePaddle] Add autopad for conv/pool

[GitBox <gi...@apache.org>]

AndrewZhaoLuo commented on a change in pull request #9295:
URL: https://github.com/apache/tvm/pull/9295#discussion_r734267270



##########
File path: python/tvm/relay/frontend/paddlepaddle.py
##########
@@ -43,18 +44,56 @@
 __all__ = ["from_paddle"]
 
 
-def _get_pad_size(in_size, dilated_kernel_size, stride_size):
-    """Calculate the paddings size for Conv/Pool in SAME padding mode."""
+def _autopad(

Review comment:
       Can you just use https://github.com/apache/tvm/blob/d0c6ca5cacae8dcae26e26287d6d2a270ab6127c/python/tvm/relay/frontend/onnx.py#L412-L472? 
   
   1. Refactor _autopad in the onnx.py file to `tvm/python/tvm/relay/frontend/common.py`

##########
File path: python/tvm/relay/frontend/paddlepaddle.py
##########
@@ -248,24 +287,13 @@ def convert_conv2d(g, op, block):
     if padding_algorithm == "VALID":
         paddings = [0, 0]
     elif padding_algorithm == "SAME":
-        if strides[0] == 1 and strides[1] == 1:
-            pad_h = _get_pad_size(0, (k_h - 1) * dilations[0] + 1, strides[0])
-            pad_w = _get_pad_size(0, (k_w - 1) * dilations[1] + 1, strides[1])
-        else:
-            input_shape = shape_of(input_x)
-            h_w = _op.strided_slice(input_shape, [2], [4])
-            try:
-                in_h, in_w = infer_value(h_w, g.get_params()).numpy().tolist()
-            except Exception as e:
-                msg = "Dynamic shape is not supported in SAME padding algorithm while stride!=1"
-                raise tvm.error.OpAttributeInvalid(msg) from e
-            pad_h = _get_pad_size(in_h, (k_h - 1) * dilations[0] + 1, strides[0])
-            pad_w = _get_pad_size(in_w, (k_w - 1) * dilations[1] + 1, strides[1])
-        paddings = [pad_h[0], pad_w[0], pad_h[1], pad_w[1]]
+        dilations = [1, 1]

Review comment:
       do we mean to override the dilations?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org