You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/12/14 19:49:38 UTC

[GitHub] [incubator-sedona] umartin opened a new pull request, #734: [SEDONA-205] Use BinaryType in GeometryUDT in Sedona Spark.

umartin opened a new pull request, #734:
URL: https://github.com/apache/incubator-sedona/pull/734

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-205. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   
   Use the more specialized type, BinaryType, in GeometryUDT for less overhead.
   
   It seems that I stumbled upon the same flaky test as in https://github.com/apache/incubator-sedona/pull/733. I will rebase this patch when the other PR is merged.
   
   ## How was this patch tested?
   
   All unit tests pass.
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu merged pull request #734: [SEDONA-205] Use BinaryType in GeometryUDT in Sedona Spark.

Posted by GitBox <gi...@apache.org>.
jiayuasu merged PR #734:
URL: https://github.com/apache/incubator-sedona/pull/734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on pull request #734: [SEDONA-205] Use BinaryType in GeometryUDT in Sedona Spark.

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #734:
URL: https://github.com/apache/incubator-sedona/pull/734#issuecomment-1352585771

   @umartin Martin, please rebase this PR and I will merge it :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] Kontinuation commented on pull request #734: [SEDONA-205] Use BinaryType in GeometryUDT in Sedona Spark.

Posted by GitBox <gi...@apache.org>.
Kontinuation commented on PR #734:
URL: https://github.com/apache/incubator-sedona/pull/734#issuecomment-1352447115

   > This is somewhat related to the awesome work by @Kontinuation in https://issues.apache.org/jira/browse/SEDONA-207 Although this patch only changes the Spark type once serialized and SEDONA-207 addresses the actual serialization.
   > 
   > @Kontinuation if you are already doing these changes in your work we can hold this PR
   
   There is no conflict with my work in regard to this pull request, maybe we can go ahead and merge your PR first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] umartin commented on pull request #734: [SEDONA-205] Use BinaryType in GeometryUDT in Sedona Spark.

Posted by GitBox <gi...@apache.org>.
umartin commented on PR #734:
URL: https://github.com/apache/incubator-sedona/pull/734#issuecomment-1352069808

   This is somewhat related to the awesome work by @Kontinuation in https://issues.apache.org/jira/browse/SEDONA-207
   Although this patch only changes the Spark type once serialized and SEDONA-207 addresses the actual serialization.
   
   @Kontinuation if you are already doing these changes in your work we can hold this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org