You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2008/05/13 21:35:55 UTC
[jira] Created: (GERONIMO-4013) Make our dependency usage the same
as maven dependency usage via car-maven-plugin
Make our dependency usage the same as maven dependency usage via car-maven-plugin
---------------------------------------------------------------------------------
Key: GERONIMO-4013
URL: https://issues.apache.org/jira/browse/GERONIMO-4013
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Affects Versions: 2.2
Reporter: David Jencks
Assignee: David Jencks
Fix For: 2.2
Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596592#action_12596592 ]
Donald Woods commented on GERONIMO-4013:
----------------------------------------
Patch also includes unrelated jaxb change to 2.1.6 -
<groupId>com.sun.xml.bind</groupId>
<artifactId>jaxb-impl</artifactId>
- <version>2.0.5</version>
+ <version>2.1.6</version>
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4013) Make our dependency usage the same
as maven dependency usage via car-maven-plugin
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated GERONIMO-4013:
-----------------------------------
Component/s: car-maven-plugin
buildsystem
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: buildsystem, car-maven-plugin
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596967#action_12596967 ]
David Jencks commented on GERONIMO-4013:
----------------------------------------
rev 656332 has a problem in that deps that are available from a car dependency and also from a transitive dependency show up as direct dependencies in the plan. We need to figure out all the geronimo transitive dependencies of each car file and avoid reintroducing these as direct dependencies.
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4013) Make our dependency usage the same
as maven dependency usage via car-maven-plugin
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-4013.
----------------------------------
Resolution: Fixed
I don't think there's any fundamental work left on this. Remaining problems if any can be new jiras.
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: buildsystem, car-maven-plugin
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596591#action_12596591 ]
Donald Woods commented on GERONIMO-4013:
----------------------------------------
Patch lso includes some other security work -
+ <gbean name="Rbac" class="org.apache.geronimo.security.jacc.rbac.RbacConfiguration">
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4013) Make our dependency usage the same
as maven dependency usage via car-maven-plugin
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated GERONIMO-4013:
-----------------------------------
Attachment: GERONIMO-4013.diff
This patch reverses the changes from GERONIMO-4012 which prevent working on this issue, changes the car-maven-plugin, uses the new flag in the gshell-* configs, and fixes things up so the build works for me. I think the gshell-* plugins are not getting used in this build but we can look at the dependencies added to the plans/geronimo-plugin.xml and see if those are reasonable.
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598060#action_12598060 ]
David Jencks commented on GERONIMO-4013:
----------------------------------------
Following some suggestions of jdillon rev 657880 eliminates use of mojo plugins support from car-maven-plugin and uses the same way to compute dependencies for the plan and plugin metadata. It also does a few less weird things to the maven module. It does require that you explicitly list all the deployment plugins you want to use, including geronimo-gbean-deployer.
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596585#action_12596585 ]
Donald Woods commented on GERONIMO-4013:
----------------------------------------
The attached patch includes the proposed changes for G4014.....
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596594#action_12596594 ]
Donald Woods commented on GERONIMO-4013:
----------------------------------------
How will the last 2 changes in the patch to car-maven-plugin work for the custom assembly creation from cmdline and admin console? The depends need to be included in boilerplate (which the current code in trunk does using standard CAR depends) so exported assemblies will include them.....
What if someone includes a newer version of a server depend in our repo? Will the transitiveDepnds correctly pull in the version that the original server was built with, or will it pull in the newer one which might not work as expected?
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596589#action_12596589 ]
Donald Woods commented on GERONIMO-4013:
----------------------------------------
Can you rework the patch to not put gshell-embeddable back in, as it includes jline and a couple other plexus jars that are at different levels than the server and is hiding the fact that we are shipping additional plexus and gshell depends....
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4013) Make our dependency usage the
same as maven dependency usage via car-maven-plugin
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597053#action_12597053 ]
David Jencks commented on GERONIMO-4013:
----------------------------------------
Time will tell but I think rev 656537 fixes this issue. We now construct our own tree modeling the dependencies and remove the ones as direct dependencies that are also available from ancestor cars. The DependencyTree maven builds won't work since it eliminates lots of duplicates, typically removing the ones farther from the starting project, those often being the ones in a car file that we want to rely on.
> Make our dependency usage the same as maven dependency usage via car-maven-plugin
> ---------------------------------------------------------------------------------
>
> Key: GERONIMO-4013
> URL: https://issues.apache.org/jira/browse/GERONIMO-4013
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Affects Versions: 2.2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 2.2
>
> Attachments: GERONIMO-4013.diff
>
>
> Right now the car-maven-plugin ignores maven transitive dependencies. One reason for this is that our build is not using our plugins as the "classloader source" of the maven dependencies that are in the plugin poms. If we restructured our build so that the pom dependency graph matched the geronimo classloader graph then perhaps we could let the car-maven-plugin follow transitive dependencies, thus making our view of dependencies pretty much the same as maven's.
> This may show up many other problems, such as too many badly scoped dependencies in all sorts of projects we use.
> One first step is to try out the car-maven-plugin with a flag for following transitive dependencies. As long as it is false we ought to get pretty much the previous behavior.
> A first use could be for the new gshell plugins so they don't have to restate all the transitive dependencies. This may show up scope problems as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.