[jira] [Work logged] (GOBBLIN-1604) Throw Allocation Error if all attempts to allocate workunits exceeds resource maximums

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1604?focusedWorklogId=721130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721130 ]

ASF GitHub Bot logged work on GOBBLIN-1604:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Feb/22 19:32
            Start Date: 04/Feb/22 19:32
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request #3461:
URL: https://github.com/apache/gobblin/pull/3461


   …ources
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1604
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   In distcp, if the size or number of files allocated by the RequestAllocator during workunit collection is too large, then Gobblin will log the error:
   ```
   // item does not fit even in empty pool
   log.warn(String.format("Request %s is larger than the available resource pool. If the pool is not expanded, "
           + "it will never be selected. Request: %s.", newElement.getT(),
   ```
   
   The job will still be marked as COMMITTED/SUCCESSFUL state. This PR makes the job in FAILED state if there are no items to be copied due to all of them being rejected
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 721130)
    Remaining Estimate: 0h
            Time Spent: 10m

> Throw Allocation Error if all attempts to allocate workunits exceeds resource maximums
> --------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1604
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1604
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In distcp, if the size or number of files allocated by the RequestAllocator during workunit collection is too large, then Gobblin will log the error:
> {code:java}
> // item does not fit even in empty pool
> log.warn(String.format("Request %s is larger than the available resource pool. If the pool is not expanded, "
>         + "it will never be selected. Request: %s.", newElement.getT(),
> {code}
> The job will still be marked as COMMITTED/SUCCESSFUL state, when it should really be partial success of FAIL if there are no workunits collected, to make the failure more visible to users.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)