You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/09/04 01:07:44 UTC

[jira] Created: (ZOOKEEPER-134) findbugs cleanup

findbugs cleanup
----------------

                 Key: ZOOKEEPER-134
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
             Project: Zookeeper
          Issue Type: Improvement
    Affects Versions: 3.0.0
            Reporter: Patrick Hunt
            Assignee: Patrick Hunt
             Fix For: 3.0.0
         Attachments: ZOOKEEPER-134.patch

cleaned up a number of findbugs warnings, in particular:

1) added @overrides appropriately
2) import cleanups
3) log or document many empty blocks
4) resource cleanup (usually by adding finally blocks)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-134:
------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed revision 692164.

> findbugs cleanup
> ----------------
>
>                 Key: ZOOKEEPER-134
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-134.patch
>
>
> cleaned up a number of findbugs warnings, in particular:
> 1) added @overrides appropriately
> 2) import cleanups
> 3) log or document many empty blocks
> 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-134) findbugs cleanup

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628955#action_12628955 ] 

Hudson commented on ZOOKEEPER-134:
----------------------------------

Integrated in ZooKeeper-trunk #76 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/76/])

> findbugs cleanup
> ----------------
>
>                 Key: ZOOKEEPER-134
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-134.patch
>
>
> cleaned up a number of findbugs warnings, in particular:
> 1) added @overrides appropriately
> 2) import cleanups
> 3) log or document many empty blocks
> 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-134:
-----------------------------------

    Attachment: ZOOKEEPER-134.patch

> findbugs cleanup
> ----------------
>
>                 Key: ZOOKEEPER-134
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-134.patch
>
>
> cleaned up a number of findbugs warnings, in particular:
> 1) added @overrides appropriately
> 2) import cleanups
> 3) log or document many empty blocks
> 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-134) findbugs cleanup

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628362#action_12628362 ] 

Benjamin Reed commented on ZOOKEEPER-134:
-----------------------------------------

+1 ready to commit

> findbugs cleanup
> ----------------
>
>                 Key: ZOOKEEPER-134
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-134.patch
>
>
> cleaned up a number of findbugs warnings, in particular:
> 1) added @overrides appropriately
> 2) import cleanups
> 3) log or document many empty blocks
> 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-134:
------------------------------------

    Hadoop Flags: [Reviewed]

> findbugs cleanup
> ----------------
>
>                 Key: ZOOKEEPER-134
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-134.patch
>
>
> cleaned up a number of findbugs warnings, in particular:
> 1) added @overrides appropriately
> 2) import cleanups
> 3) log or document many empty blocks
> 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-134:
-----------------------------------

    Status: Patch Available  (was: Open)

> findbugs cleanup
> ----------------
>
>                 Key: ZOOKEEPER-134
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-134
>             Project: Zookeeper
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-134.patch
>
>
> cleaned up a number of findbugs warnings, in particular:
> 1) added @overrides appropriately
> 2) import cleanups
> 3) log or document many empty blocks
> 4) resource cleanup (usually by adding finally blocks)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.