[GitHub] [incubator-mxnet] sjtuWangDing commented on a change in pull request #17795: [Numpy] FFI for linalg ops

[GitBox <gi...@apache.org>]

sjtuWangDing commented on a change in pull request #17795: [Numpy] FFI for linalg ops
URL: https://github.com/apache/incubator-mxnet/pull/17795#discussion_r392692391
 
 

 ##########
 File path: python/mxnet/numpy/linalg.py
 ##########
 @@ -232,7 +232,7 @@ def svd(a):
     return _mx_nd_np.linalg.svd(a)
 
 
-def cholesky(a):
+def cholesky(a, lower=True):
 
 Review comment:
   Official numpy not support 'lower'. At the backend, the implementation of 'cholesky' is to call 'potrf' in the file la_op-inl.h, and it needs a parameter 'lower'. I will use this parameter directly in the return statement, just like '_api_internal.cholesky(a, True)' and interface will be the same as official numpy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services