[GitHub] [pinot] npawar commented on a change in pull request #8004: Rename TableCache to DefaultPinotConfigProvider

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #8004:
URL: https://github.com/apache/pinot/pull/8004#discussion_r783359353



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
##########
@@ -232,26 +232,27 @@ public void start()
     boolean caseInsensitive =
         _brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, false) || _brokerConf.getProperty(
             Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, false);
-    TableCache tableCache = new TableCache(_propertyStore, caseInsensitive);
+    DefaultPinotConfigProvider defaultPinotConfigProvider =

Review comment:
       i tried to, but there's still `isCaseSensitive` and `getActualTableName` methods used from the impl. 
   I could just skip this PR and figure out what to do with those and then re-open, or I could just get the renaming in and then figure those out in a follow-up (figuring that might take some tie since I don't have the exact context on why thay are there in the first place)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org