You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/05 11:49:14 UTC
[GitHub] [doris] sohardforaname opened a new pull request, #15655: [Fix](Nereids)fix left() and right() parse error
sohardforaname opened a new pull request, #15655:
URL: https://github.com/apache/doris/pull/15655
# Proposed changes
Issue Number: close #xxx
## Problem summary
fix left() and right() parse error
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15655: [Fix](Nereids)fix left() and right() parse error
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15655:
URL: https://github.com/apache/doris/pull/15655#issuecomment-1372373499
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.59 seconds
load time: 471 seconds
storage size: 17122688400 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230105153443_clickbench_pr_74358.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #15655: [Fix](Nereids)fix left() and right() parse error
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #15655:
URL: https://github.com/apache/doris/pull/15655#discussion_r1064648972
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -365,6 +365,7 @@ errorCapturingIdentifierExtra
identifier
: strictIdentifier
+ | LEFT | RIGHT
Review Comment:
left and right cannot be column name or table name, maybe we need a new set for function name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #15655: [Fix](Nereids)fix left() and right() parse error
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #15655:
URL: https://github.com/apache/doris/pull/15655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15655: [Fix](Nereids)fix left() and right() parse error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15655:
URL: https://github.com/apache/doris/pull/15655#issuecomment-1378754743
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15655: [Fix](Nereids)fix left() and right() parse error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15655:
URL: https://github.com/apache/doris/pull/15655#issuecomment-1378754807
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org