[jira] [Commented] (AIRFLOW-5147) Annotations for k8s executors should support extended alphabet (like '/'))

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907384#comment-16907384 ] 

ASF GitHub Bot commented on AIRFLOW-5147:
-----------------------------------------

andrei-l commented on pull request #5819: [AIRFLOW-5147] extended character set for for k8s worker pods annotations
URL: https://github.com/apache/airflow/pull/5819
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-5147
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   This PR fixes the previous solution (https://github.com/apache/airflow/pull/4589) of providing k8s annotations to workers created by k8s executor. Previously each annotation key had to be declared as part of the airflow config key which implied having some limitations on it (like it could not contatin `/` character). 
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
    ```
   executors.TestKubeConfig.test_kube_config_worker_annotations_properly_parsed
   executors.TestKubeConfig.test_kube_config_no_worker_annotations
   ```
   and updates
   ```
   executors.TestKubernetesWorkerConfiguration.test_make_pod_with_empty_executor_config
   ```
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Annotations for k8s executors should support extended alphabet (like '/')) 
> ---------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5147
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5147
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: executor-kubernetes, executors
>    Affects Versions: 1.10.3, 1.10.4
>            Reporter: Andrei Loginov
>            Assignee: Daniel Imberman
>            Priority: Major
>
> The fix to introduce k8s annotations for executors ([https://github.com/apache/airflow/pull/4589] for https://issues.apache.org/jira/browse/AIRFLOW-3766) limited the character set allowed for the annotation key to [-._a-zA-Z0-9] set. However many annotations contain `/` in it, for example: 
> {code:java}
> injector.tumblr.com/request{code}
>  or
> {code:java}
> iam.amazonaws.com/role{code}
> Which would not be allowed in the current solution.
>  
> I believe original solution should be completely revisited. And instead of using a separate *kubernetes_annotations* section there should be a key which will contain a set of key:value annotations in some format. E.g. json:
> {code:java}
> [kubernetes]
> annotations = { "iam.amazonaws.com/role": "arn:aws:iam:::role/some-role-CKU5HL9BIPXG", "some-other-anno-key": "some/value" }
> {code}
>  
> Supported character set for annotations:
> https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#syntax-and-character-set



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)