You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Yixue (Andrew) Zhu" <yx...@gmail.com> on 2012/10/25 03:17:55 UTC
Review Request: Backup topic-sub inside InMemorySubscriptionManager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7731/
-----------------------------------------------------------
Review request for bookkeeper, Ivan Kelly, Sijie Guo, and Aniruddha Laud.
Description
-------
On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
This change address the issue.
This addresses bug BOOKKEEPER-441.
https://issues.apache.org/jira/browse/BOOKKEEPER-441
Diffs
-----
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java 5552265
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionManager.java 1400e49
Diff: https://reviews.apache.org/r/7731/diff/
Testing
-------
Unit tests
Thanks,
Yixue (Andrew) Zhu
Re: Review Request: Backup topic-sub inside InMemorySubscriptionManager
Posted by "Yixue (Andrew) Zhu" <yx...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7731/
-----------------------------------------------------------
(Updated Oct. 25, 2012, 4:52 p.m.)
Review request for bookkeeper, Ivan Kelly, Sijie Guo, and Aniruddha Laud.
Changes
-------
Updated patch per comment
Description
-------
On topic loss, InMemorySubscriptionManager currently does not clear top2sub2seq. The intent is to allow readSubscription to get the information there. This introduce dependency outside the class, evidence is that general ReleaseOp has to use a boolean parameter which targets this implementation detail. Further, this prevents Acquire-topic to notify listeners (notifyFirstLocalSubscribe is not called) of first subscription to act appropriately.
This change address the issue.
This addresses bug BOOKKEEPER-441.
https://issues.apache.org/jira/browse/BOOKKEEPER-441
Diffs (updated)
-----
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java 5552265
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionManager.java 1400e49
Diff: https://reviews.apache.org/r/7731/diff/
Testing
-------
Unit tests
Thanks,
Yixue (Andrew) Zhu