You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ja...@apache.org on 2018/09/02 02:38:34 UTC
[cordova-windows] branch master updated: CB-14225 fix sample
Namespace Serialize attribute in template/Properties/Default.rd.xml (#286)
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git
The following commit(s) were added to refs/heads/master by this push:
new 03f482d CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml (#286)
03f482d is described below
commit 03f482dfee44809b9e289af3721eccb31884bc53
Author: Chris Brody <ch...@gmail.com>
AuthorDate: Sat Sep 1 22:38:31 2018 -0400
CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml (#286)
### Original issue
<https://issues.apache.org/jira/browse/CB-14225>
### Platforms affected
Windows
### What does this PR do?
- Fix sample Namespace Serialize attribute in `template/Properties/Default.rd.xml`, according to `Default.rd.xml` in C# UWP project generated by Visual Studio 2017
I also raised <https://github.com/Microsoft/Windows-universal-samples/pull/950> to apply a similar fix there.
Also related:
- #284 - fix license text & add link to `template/Properties/Default.rd.xml` (as reported in <https://issues.apache.org/jira/browse/CB-14224>)
- <https://github.com/Microsoft/Windows-universal-samples/pull/949> - fix license txt (related to but not part of #284)
### What testing has been done on this change?
- Visual inspection
- check diff
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- ~~Added automated test coverage as appropriate for this change.~~
---
template/Properties/Default.rd.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/template/Properties/Default.rd.xml b/template/Properties/Default.rd.xml
index 3b46199..4ab5e93 100644
--- a/template/Properties/Default.rd.xml
+++ b/template/Properties/Default.rd.xml
@@ -12,7 +12,7 @@
<TypeInstantiation Name="App1.AppClass" Arguments="System.Int32" Activate="Required Public" />
Using the Namespace directive to apply reflection policy to all the types in a particular namespace
- <Namespace Name="DataClasses.ViewModels" Seralize="All" />
+ <Namespace Name="DataClasses.ViewModels" Serialize="All" />
The MIT License (MIT)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org