You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Dmitriy Shirchenko <ca...@gmail.com> on 2016/04/19 04:31:41 UTC
Review Request 46361: deleting --setuid-health-checks and switching to
--nosetuid-health-checks flag to to control whether the executor runs
health checks as the job role's user.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46361/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.
Diffs
-----
RELEASE-NOTES.md 2068d9c141b79643f0c0687a0834a37b3af9955c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0b3c38c298ab54dce65d7b1dc4d965fdf833acc0
src/main/python/apache/aurora/executor/common/health_checker.py 88b629e944ab653e8acb9a8d20cdded125a8ac73
src/test/python/apache/aurora/executor/common/test_health_checker.py ff39e869634830b0eb59ddfe52a5a48ca1605a66
Diff: https://reviews.apache.org/r/46361/diff/
Testing
-------
Thanks,
Dmitriy Shirchenko
Re: Review Request 46361: deleting --setuid-health-checks and
switching to
--nosetuid-health-checks flag to to control whether the executor runs
health checks as the job role's user.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46361/#review129600
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 18, 2016, 7:31 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46361/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 7:31 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1666
> https://issues.apache.org/jira/browse/AURORA-1666
>
>
> Repository: aurora
>
>
> Description
> -------
>
> deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 2068d9c141b79643f0c0687a0834a37b3af9955c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0b3c38c298ab54dce65d7b1dc4d965fdf833acc0
> src/main/python/apache/aurora/executor/common/health_checker.py 88b629e944ab653e8acb9a8d20cdded125a8ac73
> src/test/python/apache/aurora/executor/common/test_health_checker.py ff39e869634830b0eb59ddfe52a5a48ca1605a66
>
> Diff: https://reviews.apache.org/r/46361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 46361: deleting --setuid-health-checks and
switching to
--nosetuid-health-checks flag to to control whether the executor runs
health checks as the job role's user.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46361/#review129474
-----------------------------------------------------------
Ship it!
Master (96d5b64) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 19, 2016, 2:31 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46361/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 2:31 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1666
> https://issues.apache.org/jira/browse/AURORA-1666
>
>
> Repository: aurora
>
>
> Description
> -------
>
> deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 2068d9c141b79643f0c0687a0834a37b3af9955c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0b3c38c298ab54dce65d7b1dc4d965fdf833acc0
> src/main/python/apache/aurora/executor/common/health_checker.py 88b629e944ab653e8acb9a8d20cdded125a8ac73
> src/test/python/apache/aurora/executor/common/test_health_checker.py ff39e869634830b0eb59ddfe52a5a48ca1605a66
>
> Diff: https://reviews.apache.org/r/46361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 46361: deleting --setuid-health-checks and
switching to
--nosetuid-health-checks flag to to control whether the executor runs
health checks as the job role's user.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46361/#review129562
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On April 18, 2016, 7:31 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46361/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 7:31 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1666
> https://issues.apache.org/jira/browse/AURORA-1666
>
>
> Repository: aurora
>
>
> Description
> -------
>
> deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 2068d9c141b79643f0c0687a0834a37b3af9955c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0b3c38c298ab54dce65d7b1dc4d965fdf833acc0
> src/main/python/apache/aurora/executor/common/health_checker.py 88b629e944ab653e8acb9a8d20cdded125a8ac73
> src/test/python/apache/aurora/executor/common/test_health_checker.py ff39e869634830b0eb59ddfe52a5a48ca1605a66
>
> Diff: https://reviews.apache.org/r/46361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 46361: deleting --setuid-health-checks and
switching to
--nosetuid-health-checks flag to to control whether the executor runs
health checks as the job role's user.
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46361/
-----------------------------------------------------------
(Updated April 19, 2016, 2:31 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1666
https://issues.apache.org/jira/browse/AURORA-1666
Repository: aurora
Description
-------
deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.
Diffs
-----
RELEASE-NOTES.md 2068d9c141b79643f0c0687a0834a37b3af9955c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0b3c38c298ab54dce65d7b1dc4d965fdf833acc0
src/main/python/apache/aurora/executor/common/health_checker.py 88b629e944ab653e8acb9a8d20cdded125a8ac73
src/test/python/apache/aurora/executor/common/test_health_checker.py ff39e869634830b0eb59ddfe52a5a48ca1605a66
Diff: https://reviews.apache.org/r/46361/diff/
Testing
-------
Thanks,
Dmitriy Shirchenko