You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/04/16 12:15:16 UTC
[GitHub] [kafka] dengziming opened a new pull request, #12060: KAFKA-13832: Fix flaky testAlterAssignment
dengziming opened a new pull request, #12060:
URL: https://github.com/apache/kafka/pull/12060
*More detailed description of your change*
In KRaft mode the metadata is not propagate in time, so we should should wait for it before make assertions.
*Summary of testing strategy (including rationale)*
No
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a diff in pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment
Posted by GitBox <gi...@apache.org>.
dengziming commented on code in PR #12060:
URL: https://github.com/apache/kafka/pull/12060#discussion_r852639804
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -320,6 +320,9 @@ class TopicCommandIntegrationTest extends KafkaServerTestHarness with Logging wi
topicService.alterTopic(new TopicCommandOptions(
Array("--topic", testTopicName, "--replica-assignment", "5:3,3:1,4:2", "--partitions", "3")))
+ TestUtils.waitUntilTrue(
+ () => brokers.forall(_.metadataCache.getTopicPartitions(testTopicName).size == 3),
+ "Timeout waiting new assignment propagate to broker")
Review Comment:
Thank you for the suggestions, have rectified all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment
Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #12060:
URL: https://github.com/apache/kafka/pull/12060#discussion_r852634046
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -320,6 +320,9 @@ class TopicCommandIntegrationTest extends KafkaServerTestHarness with Logging wi
topicService.alterTopic(new TopicCommandOptions(
Array("--topic", testTopicName, "--replica-assignment", "5:3,3:1,4:2", "--partitions", "3")))
+ TestUtils.waitUntilTrue(
+ () => brokers.forall(_.metadataCache.getTopicPartitions(testTopicName).size == 3),
+ "Timeout waiting new assignment propagate to broker")
Review Comment:
nit: Timeout waiting [for] new assignment [propagating] to broker
Same comment apply to 2 other places in the same test file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12060:
URL: https://github.com/apache/kafka/pull/12060#issuecomment-1102148265
@dengziming , sorry, one more little thing that you missed in my previous "edited" comment.
Timeout waiting for new assignment [propagating] to broker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12060:
URL: https://github.com/apache/kafka/pull/12060#issuecomment-1102137990
Note: All tests passed in Jenkins!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment
Posted by GitBox <gi...@apache.org>.
showuon merged PR #12060:
URL: https://github.com/apache/kafka/pull/12060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment
Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #12060:
URL: https://github.com/apache/kafka/pull/12060#discussion_r852634046
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -320,6 +320,9 @@ class TopicCommandIntegrationTest extends KafkaServerTestHarness with Logging wi
topicService.alterTopic(new TopicCommandOptions(
Array("--topic", testTopicName, "--replica-assignment", "5:3,3:1,4:2", "--partitions", "3")))
+ TestUtils.waitUntilTrue(
+ () => brokers.forall(_.metadataCache.getTopicPartitions(testTopicName).size == 3),
+ "Timeout waiting new assignment propagate to broker")
Review Comment:
nit: Timeout waiting [for] new assignment....
Same comment apply to 2 other places in the same test file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #12060: KAFKA-13832: Fix flaky testAlterAssignment
Posted by GitBox <gi...@apache.org>.
dengziming commented on PR #12060:
URL: https://github.com/apache/kafka/pull/12060#issuecomment-1102160292
@showuon Aha, this is reasonable, I pushed another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org