Mechanics of Twitter Commons Import

[Zameer Manji <zm...@apache.org>]

Hey,

I would like to inform everyone that there is a review
<https://reviews.apache.org/r/37666/> out that imports the java code we
depend on from Twitter Commons into our tree. The current approach of the
import is a large patch on RB with a description that explains the origin
of the code. The benefits of this approach ensures our commit history
remains linear and easy to bisect. However this approach means that our
repo will not contain the history of these files. Currently I believe there
is no value in preserving history since we do not intend to maintain this
code for a long time and the history of files is easily available on github.

Please +1 or -1 this approach.

-- 
Zameer Manji

Re: Mechanics of Twitter Commons Import

[Maxim Khutornenko <ma...@apache.org>]

I am +1 given there is no easy way to accomplish what we want exactly.

I still think the history is valuable though and especially so during
the component migration work when the deep understanding of
functionality and tradeoffs of modules being replaced is vital.

On Mon, Aug 24, 2015 at 5:18 PM, Bill Farner <wf...@apache.org> wrote:
> +1
>
> -=Bill
>
> On Mon, Aug 24, 2015 at 5:16 PM, Kevin Sweeney <ke...@apache.org> wrote:
>
>> +1
>>
>> On Mon, Aug 24, 2015 at 5:14 PM, Zameer Manji <zm...@apache.org> wrote:
>>
>> > Hey,
>> >
>> > I would like to inform everyone that there is a review
>> > <https://reviews.apache.org/r/37666/> out that imports the java code we
>> > depend on from Twitter Commons into our tree. The current approach of the
>> > import is a large patch on RB with a description that explains the origin
>> > of the code. The benefits of this approach ensures our commit history
>> > remains linear and easy to bisect. However this approach means that our
>> > repo will not contain the history of these files. Currently I believe
>> there
>> > is no value in preserving history since we do not intend to maintain this
>> > code for a long time and the history of files is easily available on
>> > github.
>> >
>> > Please +1 or -1 this approach.
>> >
>> > --
>> > Zameer Manji
>> >
>>

Re: Mechanics of Twitter Commons Import

[Bill Farner <wf...@apache.org>]

+1

-=Bill

On Mon, Aug 24, 2015 at 5:16 PM, Kevin Sweeney <ke...@apache.org> wrote:

> +1
>
> On Mon, Aug 24, 2015 at 5:14 PM, Zameer Manji <zm...@apache.org> wrote:
>
> > Hey,
> >
> > I would like to inform everyone that there is a review
> > <https://reviews.apache.org/r/37666/> out that imports the java code we
> > depend on from Twitter Commons into our tree. The current approach of the
> > import is a large patch on RB with a description that explains the origin
> > of the code. The benefits of this approach ensures our commit history
> > remains linear and easy to bisect. However this approach means that our
> > repo will not contain the history of these files. Currently I believe
> there
> > is no value in preserving history since we do not intend to maintain this
> > code for a long time and the history of files is easily available on
> > github.
> >
> > Please +1 or -1 this approach.
> >
> > --
> > Zameer Manji
> >
>

Re: Mechanics of Twitter Commons Import

[Kevin Sweeney <ke...@apache.org>]

+1

On Mon, Aug 24, 2015 at 5:14 PM, Zameer Manji <zm...@apache.org> wrote:

> Hey,
>
> I would like to inform everyone that there is a review
> <https://reviews.apache.org/r/37666/> out that imports the java code we
> depend on from Twitter Commons into our tree. The current approach of the
> import is a large patch on RB with a description that explains the origin
> of the code. The benefits of this approach ensures our commit history
> remains linear and easy to bisect. However this approach means that our
> repo will not contain the history of these files. Currently I believe there
> is no value in preserving history since we do not intend to maintain this
> code for a long time and the history of files is easily available on
> github.
>
> Please +1 or -1 this approach.
>
> --
> Zameer Manji
>

Re: Mechanics of Twitter Commons Import

[Henry Saputra <he...@gmail.com>]

+1

Should be ok

On Mon, Aug 24, 2015 at 5:14 PM, Zameer Manji <zm...@apache.org> wrote:
> Hey,
>
> I would like to inform everyone that there is a review
> <https://reviews.apache.org/r/37666/> out that imports the java code we
> depend on from Twitter Commons into our tree. The current approach of the
> import is a large patch on RB with a description that explains the origin
> of the code. The benefits of this approach ensures our commit history
> remains linear and easy to bisect. However this approach means that our
> repo will not contain the history of these files. Currently I believe there
> is no value in preserving history since we do not intend to maintain this
> code for a long time and the history of files is easily available on github.
>
> Please +1 or -1 this approach.
>
> --
> Zameer Manji