You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by nf...@apache.org on 2019/12/11 18:37:52 UTC

[camel-k] 02/08: Fix #1120: remove kaniko build cache default setting in spec

This is an automated email from the ASF dual-hosted git repository.

nferraro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-k.git

commit bcd24eec4ab4c1dcc36731b0574a8a83ceeab789
Author: Nicola Ferraro <ni...@gmail.com>
AuthorDate: Mon Dec 9 11:03:24 2019 +0100

    Fix #1120: remove kaniko build cache default setting in spec
---
 pkg/apis/camel/v1alpha1/common_types.go | 2 +-
 pkg/cmd/install.go                      | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/pkg/apis/camel/v1alpha1/common_types.go b/pkg/apis/camel/v1alpha1/common_types.go
index f54c19c..51a1885 100644
--- a/pkg/apis/camel/v1alpha1/common_types.go
+++ b/pkg/apis/camel/v1alpha1/common_types.go
@@ -87,7 +87,7 @@ type ValueSource struct {
 	// Selects a key of a ConfigMap.
 	ConfigMapKeyRef *corev1.ConfigMapKeySelector `json:"configMapKeyRef,omitempty"`
 	// Selects a key of a secret.
-	SecretKeyRef *corev1.SecretKeySelector `json:"secretKeyRef,omitempty" `
+	SecretKeyRef *corev1.SecretKeySelector `json:"secretKeyRef,omitempty"`
 }
 
 const (
diff --git a/pkg/cmd/install.go b/pkg/cmd/install.go
index c3af624..97b84f5 100644
--- a/pkg/cmd/install.go
+++ b/pkg/cmd/install.go
@@ -269,12 +269,8 @@ func (o *installCmdOptions) install(cobraCmd *cobra.Command, _ []string) error {
 
 		kanikoBuildCacheFlag := cobraCmd.Flags().Lookup("kaniko-build-cache")
 
-		defaultKanikoBuildCache := true
-
 		if kanikoBuildCacheFlag.Changed {
 			platform.Spec.Build.KanikoBuildCache = &o.kanikoBuildCache
-		} else {
-			platform.Spec.Build.KanikoBuildCache = &defaultKanikoBuildCache
 		}
 
 		platform.Spec.Resources.Kits = o.kits