You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/03/21 13:18:34 UTC
Review Request 19527: Mirroring: filter out non-Ambari mirroring feeds by
naming convention
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19527/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-5172
https://issues.apache.org/jira/browse/AMBARI-5172
Repository: ambari
Description
-------
Once Falcon is deployed, Falcon can be used to set up feeds for purposes other than Ambari-managed mirroring jobs.
Currently, all feeds set up in Falcon out-of-band show up in the Mirroring UI.
When Ambari creates feeds for mirroring purposes,
We can prefix with ambari_mirroring_<feed name in UI>.
When displaying feeds in the Mirroring UI:
* Do not show any feeds that do not start with ambari-mirroring-.
* When showing feeds, strip out ambari-mirroring-. (For example, *ambari-mirroring-applogs* should be shown as *applogs*).
Diffs
-----
ambari-web/app/config.js a6445eb
ambari-web/app/controllers/main/mirroring/edit_dataset_controller.js 2250118
ambari-web/app/controllers/main/mirroring/jobs_controller.js 607efb1
ambari-web/app/controllers/main/mirroring_controller.js c515048
ambari-web/app/models/dataset.js 20f90d8
Diff: https://reviews.apache.org/r/19527/diff/
Testing
-------
2537 tests complete (866 ms)
Thanks,
Aleksandr Kovalenko
Re: Review Request 19527: Mirroring: filter out non-Ambari mirroring feeds
by naming convention
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19527/#review38087
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On March 21, 2014, 12:18 p.m., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19527/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 12:18 p.m.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-5172
> https://issues.apache.org/jira/browse/AMBARI-5172
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Once Falcon is deployed, Falcon can be used to set up feeds for purposes other than Ambari-managed mirroring jobs.
> Currently, all feeds set up in Falcon out-of-band show up in the Mirroring UI.
>
> When Ambari creates feeds for mirroring purposes,
> We can prefix with ambari_mirroring_<feed name in UI>.
> When displaying feeds in the Mirroring UI:
> * Do not show any feeds that do not start with ambari-mirroring-.
> * When showing feeds, strip out ambari-mirroring-. (For example, *ambari-mirroring-applogs* should be shown as *applogs*).
>
>
> Diffs
> -----
>
> ambari-web/app/config.js a6445eb
> ambari-web/app/controllers/main/mirroring/edit_dataset_controller.js 2250118
> ambari-web/app/controllers/main/mirroring/jobs_controller.js 607efb1
> ambari-web/app/controllers/main/mirroring_controller.js c515048
> ambari-web/app/models/dataset.js 20f90d8
>
> Diff: https://reviews.apache.org/r/19527/diff/
>
>
> Testing
> -------
>
> 2537 tests complete (866 ms)
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>