[GitHub] [linkis] peacewong commented on a diff in pull request #4731: [Bug][ECM]Script to kill process should to skip ECM pid

["peacewong (via GitHub)" <gi...@apache.org>]

peacewong commented on code in PR #4731:
URL: https://github.com/apache/linkis/pull/4731#discussion_r1251781934


##########
linkis-dist/package/sbin/kill-process-by-pid.sh:
##########
@@ -14,68 +14,59 @@
 # limitations under the License.
 #
 
-function list_descendants ()
-{
-  ppid=$1
-  local children=$(pgrep -P ${ppid})
+cd `dirname $0`
+cd ..
+INSTALL_HOME=`pwd`
+# set LINKIS_HOME
+if [ "$LINKIS_HOME" = "" ]; then
+  export LINKIS_HOME=$INSTALL_HOME
+fi
+if [ "$LINKIS_LOG_DIR" = "" ]; then
+  export LINKIS_LOG_DIR="/data/bdp/logs/linkis"

Review Comment:
   ok,Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org