You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/18 03:07:41 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #10288: feat: Dynamically imported viz plugins
codecov-io commented on pull request #10288:
URL: https://github.com/apache/incubator-superset/pull/10288#issuecomment-747839275
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=h1) Report
> Merging [#10288](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=desc) (680feb2) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92fdf54aa34ed2edd5c85b5b47053bf4ce559517?el=desc) (92fdf54) will **decrease** coverage by `3.47%`.
> The diff coverage is `70.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10288 +/- ##
==========================================
- Coverage 66.71% 63.23% -3.48%
==========================================
Files 967 484 -483
Lines 47543 29695 -17848
Branches 4650 0 -4650
==========================================
- Hits 31716 18778 -12938
+ Misses 15706 10917 -4789
+ Partials 121 0 -121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.23% <70.45%> (-0.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.51% <ø> (ø)` | |
| [...ns/versions/73fd22e742ab\_add\_dynamic\_plugins\_py.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83M2ZkMjJlNzQyYWJfYWRkX2R5bmFtaWNfcGx1Z2luc19weS5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | |
| [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.57% <66.66%> (-0.16%)` | :arrow_down: |
| [superset/models/dynamic\_plugins.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2R5bmFtaWNfcGx1Z2lucy5weQ==) | `90.00% <90.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.23% <100.00%> (-0.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.07% <100.00%> (-0.53%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [511 more](https://codecov.io/gh/apache/incubator-superset/pull/10288/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=footer). Last update [92fdf54...7624937](https://codecov.io/gh/apache/incubator-superset/pull/10288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org