You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "iamsanjay (via GitHub)" <gi...@apache.org> on 2024/06/04 16:15:03 UTC

[PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

iamsanjay opened a new pull request, #2497:
URL: https://github.com/apache/solr/pull/2497

https://issues.apache.org/jira/browse/SOLR-17321

<!--
_(If you are a project committer then you may remove some/all of the following template.)_

Before creating a pull request, please file an issue in the ASF Jira system for Solr:

* https://issues.apache.org/jira/projects/SOLR

For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.

The title of the PR should reference the Jira issue number in the form:

* SOLR-####: <short description of problem or changes>

SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.

Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->

We are upgrading the minimum Java version for Solr main branch to 21. However, at the same, It has been suggested to be not so aggressive with SolrJ (and thus solr-api, a dependency) Java version – setting it to 17.

# Checklist

Please review the following and check all that apply:

- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.

dsmiley commented on code in PR #2497:
URL: https://github.com/apache/solr/pull/2497#discussion_r1626476316


##########
solr/core/src/test/org/apache/solr/cli/PostToolTest.java:
##########
@@ -210,6 +211,7 @@ public void testAppendParam() {
   }
 
   @Test
+  @SuppressForbidden(reason = "java.net.URL ctors deprecated since Java 20")

Review Comment:
   can this be put at the class level once instead of most tests?



##########
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##########
@@ -256,10 +257,12 @@ public void runImpl(CommandLine cli) throws Exception {
     solrUpdateUrl = null;
     if (cli.hasOption("url")) {
       String url = cli.getOptionValue("url");
-      solrUpdateUrl = new URL(url);
+      URI uri = new URI(url);

Review Comment:
   nitpick: inline



##########
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##########
@@ -844,7 +844,8 @@ public void doTestIndexFetchWithLeaderUrl() throws Exception {
             + "/"
             + DEFAULT_TEST_CORENAME
             + ReplicationHandler.PATH;
-    URL url = new URL(leaderUrl);
+    URI uri = new URI(leaderUrl);
+    URL url = uri.toURL();

Review Comment:
   inline to one-liner



##########
gradle/validation/dependency-analyze.gradle:
##########
@@ -23,14 +23,14 @@ allprojects { prj ->
     prj.apply plugin: 'ca.cutterslade.analyze'
 
     analyzeClassesDependencies {
-      warnUsedUndeclared = false // means fail build if UsedUndeclared found
-      warnUnusedDeclared = false // means fail build if UnusedDeclared found
+      warnUsedUndeclared = true // means fail build if UsedUndeclared found

Review Comment:
   you updated booleans but not the explanatory comment.  Why change this any way?



##########
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##########
@@ -86,7 +86,7 @@
  *
  * @since 1.4
  */
-@LuceneTestCase.Nightly
+// @LuceneTestCase.Nightly

Review Comment:
   Why?



##########
solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java:
##########
@@ -134,6 +135,7 @@ public static void setupCluster() throws Exception {
   }
 
   @SuppressWarnings("serial")
+  @SuppressForbidden(reason = "java.net.URL ctors deprecated since Java 20")

Review Comment:
   You fix some and suppress others.  Is there a pattern/approach to it?  (just curious; maybe not)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org