[GitHub] [beam] chamikaramj commented on a change in pull request #11607: [BEAM-9430] Fixes the bounds of initial watermark set to estimators instead of raising an error

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #11607:
URL: https://github.com/apache/beam/pull/11607#discussion_r421826896



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimators.java
##########
@@ -37,14 +37,16 @@
     private Instant lastReportedWatermark;
 
     public Manual(Instant watermark) {
-      this.watermark = checkNotNull(watermark, "watermark must not be null.");
-      if (watermark.isBefore(GlobalWindow.TIMESTAMP_MIN_VALUE)
-          || watermark.isAfter(GlobalWindow.TIMESTAMP_MAX_VALUE)) {
-        throw new IllegalArgumentException(
-            String.format(
-                "Provided watermark %s must be within bounds [%s, %s].",
-                watermark, GlobalWindow.TIMESTAMP_MIN_VALUE, GlobalWindow.TIMESTAMP_MAX_VALUE));
+      checkNotNull(watermark, "watermark must not be null.");
+
+      // Making sure that the watermark is within bounds.

Review comment:
       What's the difference between those values. Seems like GlobalWindow get's these constants from the super class BoundedWindow ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org