You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/25 15:30:09 UTC
Re: Review Request 70895: Added a test for supperssing roles via V0
updateFramework().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70895/
-----------------------------------------------------------
(Updated June 25, 2019, 3:30 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Added a test for supperssing roles via V0 updateFramework().
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description (updated)
-------
Added a test for supperssing roles via V0 updateFramework().
Diffs (updated)
-----
src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
Diff: https://reviews.apache.org/r/70895/diff/2/
Changes: https://reviews.apache.org/r/70895/diff/1-2/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*SuppressedRoles" --gtest_break_on_failure --gtest_repeat=1000`
Thanks,
Andrei Sekretenko
Re: Review Request 70895: Added a test for suppressing roles via V0
updateFramework().
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70895/#review216295
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On June 26, 2019, 3:33 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70895/
> -----------------------------------------------------------
>
> (Updated June 26, 2019, 3:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for suppressing roles via V0 updateFramework().
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
>
>
> Diff: https://reviews.apache.org/r/70895/diff/4/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*SuppressedRoles" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70895: Added a test for suppressing roles via V0
updateFramework().
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70895/
-----------------------------------------------------------
(Updated June 26, 2019, 3:33 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Added a test for suppressing roles via V0 updateFramework().
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description (updated)
-------
Added a test for suppressing roles via V0 updateFramework().
Diffs (updated)
-----
src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
Diff: https://reviews.apache.org/r/70895/diff/3/
Changes: https://reviews.apache.org/r/70895/diff/2-3/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*SuppressedRoles" --gtest_break_on_failure --gtest_repeat=1000`
Thanks,
Andrei Sekretenko
Re: Review Request 70895: Added a test for supperssing roles via V0
updateFramework().
Posted by Andrei Sekretenko <as...@mesosphere.io>.
> On June 25, 2019, 7:21 p.m., Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 992-996 (patched)
> > <https://reviews.apache.org/r/70895/diff/2/?file=2152137#file2152137line992>
> >
> > The framework update already occurred, and it may be in the allocator's queue, but that's fine. Why is this settling?
You are right, we don't need it now - I removed it from the patch.
Is it true that the update will always be performed atomically in the allocator (i.e. no deferred calls will be initiated by the allocator to complete the update)?
If this changes, adding the slave will race against the update... but most likely, we will have a whole bunch of other problems then;)
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70895/#review216126
-----------------------------------------------------------
On June 25, 2019, 3:30 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70895/
> -----------------------------------------------------------
>
> (Updated June 25, 2019, 3:30 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for supperssing roles via V0 updateFramework().
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
>
>
> Diff: https://reviews.apache.org/r/70895/diff/2/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*SuppressedRoles" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70895: Added a test for suppressing roles via V0
updateFramework().
Posted by Benjamin Mahler <bm...@apache.org>.
> On June 25, 2019, 7:21 p.m., Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 992-996 (patched)
> > <https://reviews.apache.org/r/70895/diff/2/?file=2152137#file2152137line992>
> >
> > The framework update already occurred, and it may be in the allocator's queue, but that's fine. Why is this settling?
>
> Andrei Sekretenko wrote:
> You are right, we don't need it now - I removed it from the patch.
>
> Is it true that the update will always be performed atomically in the allocator (i.e. no deferred calls will be initiated by the allocator to complete the update)?
>
> If this changes, adding the slave will race against the update... but most likely, we will have a whole bunch of other problems then;)
> Is it true that the update will always be performed atomically in the allocator (i.e. no deferred calls will be initiated by the allocator to complete the update)?
It's true today, and no known ways this will become async.
> If this changes, adding the slave will race against the update... but most likely, we will have a whole bunch of other problems then;)
Yes, that sounds like something we would want to surface, since it's going to cause other bugs.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70895/#review216126
-----------------------------------------------------------
On June 26, 2019, 3:33 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70895/
> -----------------------------------------------------------
>
> (Updated June 26, 2019, 3:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for suppressing roles via V0 updateFramework().
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
>
>
> Diff: https://reviews.apache.org/r/70895/diff/3/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*SuppressedRoles" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70895: Added a test for supperssing roles via V0
updateFramework().
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70895/#review216126
-----------------------------------------------------------
s/supperssing/suppressing/
Looks good, just wondering why the settle.
src/tests/master/update_framework_tests.cpp
Lines 970 (patched)
<https://reviews.apache.org/r/70895/#comment303132>
s/std:://
src/tests/master/update_framework_tests.cpp
Lines 985 (patched)
<https://reviews.apache.org/r/70895/#comment303133>
s/std:://
src/tests/master/update_framework_tests.cpp
Lines 992-996 (patched)
<https://reviews.apache.org/r/70895/#comment303134>
The framework update already occurred, and it may be in the allocator's queue, but that's fine. Why is this settling?
- Benjamin Mahler
On June 25, 2019, 3:30 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70895/
> -----------------------------------------------------------
>
> (Updated June 25, 2019, 3:30 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for supperssing roles via V0 updateFramework().
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f
>
>
> Diff: https://reviews.apache.org/r/70895/diff/2/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkV0*SuppressedRoles" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>