You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "mfussenegger (via GitHub)" <gi...@apache.org> on 2023/09/27 13:29:13 UTC
[GitHub] [maven-surefire] mfussenegger opened a new pull request, #672: Mention toolchains limitations in docs
mfussenegger opened a new pull request, #672:
URL: https://github.com/apache/maven-surefire/pull/672
If forkCount is configured the test goal can fail with a
UnsupportedClassVersionError
Apparently this is by design:
https://issues.apache.org/jira/browse/SUREFIRE-720?focusedCommentId=16395576&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16395576
The documentation should mention a limitation like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mention toolchains limitations in docs [maven-surefire]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #672:
URL: https://github.com/apache/maven-surefire/pull/672#discussion_r1361082313
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -36,6 +36,9 @@ Using Maven Toolchains with ${thisPlugin}.
guide, ${thisPlugin} will launch the test jvm using the main toolchain
configured in Maven.
+ Note that options like <<<forkCount>>> prevent the toolchains from being used.
+ See {{{https://issues.apache.org/jira/browse/SUREFIRE-720}}SUREFIRE-720} for more information.
+
Review Comment:
Instead of pointing issue - I would like to see description how `forkCount` option impact on toolchains.
Reading issue and all comments is not easy to find clue of problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mention toolchains limitations in docs [maven-surefire]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo closed pull request #672: Mention toolchains limitations in docs
URL: https://github.com/apache/maven-surefire/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mention toolchains limitations in docs [maven-surefire]
Posted by "mfussenegger (via GitHub)" <gi...@apache.org>.
mfussenegger commented on code in PR #672:
URL: https://github.com/apache/maven-surefire/pull/672#discussion_r1367388265
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -36,6 +36,9 @@ Using Maven Toolchains with ${thisPlugin}.
guide, ${thisPlugin} will launch the test jvm using the main toolchain
configured in Maven.
+ Note that options like <<<forkCount>>> prevent the toolchains from being used.
+ See {{{https://issues.apache.org/jira/browse/SUREFIRE-720}}SUREFIRE-720} for more information.
+
Review Comment:
Isn't
> Note that options like <<<forkCount>>> prevent the toolchains from being used.
describing the impact?
I'm not familiar with the exact details why it is not working. If you expect that then someone else has to make the changes.
I'd think this is at least an improvement over the status quo, because currently it says that surefire picks up toolchains by default, while it doesn't if forkCount is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mention toolchains limitations in docs [maven-surefire]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #672:
URL: https://github.com/apache/maven-surefire/pull/672#discussion_r3838331710
##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -36,6 +36,9 @@ Using Maven Toolchains with ${thisPlugin}.
guide, ${thisPlugin} will launch the test jvm using the main toolchain
configured in Maven.
+ Note that options like <<<forkCount>>> prevent the toolchains from being used.
+ See {{{https://issues.apache.org/jira/browse/SUREFIRE-720}}SUREFIRE-720} for more information.
+
Review Comment:
more details here https://github.com/apache/maven-surefire/issues/2151#issuecomment-5364346523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org