You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "misaya295 (via GitHub)" <gi...@apache.org> on 2023/11/06 06:51:09 UTC
[PR] [type:refactor] sofa e2e [shenyu]
misaya295 opened a new pull request, #5275:
URL: https://github.com/apache/shenyu/pull/5275
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:refactor] sofa e2e [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5275:
URL: https://github.com/apache/shenyu/pull/5275#issuecomment-1794277135
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5275?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5275](https://app.codecov.io/gh/apache/shenyu/pull/5275?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ef5bf9f) into [master](https://app.codecov.io/gh/apache/shenyu/commit/0dca04348e9ce92707e247870342e95124968191?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0dca043) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #5275 +/- ##
============================================
- Coverage 61.67% 61.59% -0.08%
+ Complexity 8741 8731 -10
============================================
Files 1252 1252
Lines 38586 38585 -1
Branches 3691 3687 -4
============================================
- Hits 23796 23768 -28
- Misses 12700 12721 +21
- Partials 2090 2096 +6
```
| [Files](https://app.codecov.io/gh/apache/shenyu/pull/5275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/shenyu/plugin/sofa/SofaPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tc29mYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9zb2ZhL1NvZmFQbHVnaW4uamF2YQ==) | `82.75% <ø> (ø)` | |
... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5275/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:refactor] sofa e2e [shenyu]
Posted by "misaya295 (via GitHub)" <gi...@apache.org>.
misaya295 commented on PR #5275:
URL: https://github.com/apache/shenyu/pull/5275#issuecomment-1794409726
pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:refactor] sofa e2e [shenyu]
Posted by "misaya295 (via GitHub)" <gi...@apache.org>.
misaya295 closed pull request #5275: [type:refactor] sofa e2e
URL: https://github.com/apache/shenyu/pull/5275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:refactor] sofa e2e [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #5275:
URL: https://github.com/apache/shenyu/pull/5275#issuecomment-1807379228
shenyu client don't support this, I think it may be closeable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org