You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by michalklempa <gi...@git.apache.org> on 2016/02/15 21:47:28 UTC
[GitHub] nifi pull request: nifi-1514 - Fixed: ExecuteStreamCommand does no...
GitHub user michalklempa opened a pull request:
https://github.com/apache/nifi/pull/223
nifi-1514 - Fixed: ExecuteStreamCommand does not split command line arguments by provided separator when these come from expression language evaluation
nifi-1514 - Fixed: ExecuteStreamCommand does not split command line arguments by provided separator when these come from expression language evaluation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michalklempa/nifi nifi-1514
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #223
----
commit 62009f42f9a0950fc19b6b2ef333eb90a15ff1e0
Author: Michal Klempa <mi...@gmail.com>
Date: 2016-02-15T20:38:26Z
nifi-1514 Fixed: ExecuteStreamCommand when expressions in command arguments are used, contents are not splitted by command separator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: nifi-1514 - Fixed: ExecuteStreamCommand does no...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/223#issuecomment-185443013
@michalklempa looks good. one minor point that I am adjusting is the usage of newProperty at https://github.com/apache/nifi/pull/223/files#diff-fe8e954d730443b47cb0a94d340ac271R306 This is typically for dynamic properties where new values must be created because there is no a priori knowledge of them.
Regardless, thanks for detecting and fixing this up and it will be merged shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: nifi-1514 - Fixed: ExecuteStreamCommand does no...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---