You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/05/15 14:18:47 UTC
Review Request: Fix CLOUDSTACK-2513 VPN tests refer to invalid
connection.user in cloudConnection
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11179/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Description
-------
cloudConnection object should always have "user" and "passwd" attributes.
And they are "None" while creating userAPIClient. As we already
have "user" and "password" for mgmt server.
This addresses bug CLOUDSTACK-2513.
Diffs
-----
tools/marvin/marvin/cloudstackConnection.py b5ff5bf
Diff: https://reviews.apache.org/r/11179/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request: Fix CLOUDSTACK-2513 VPN tests refer to invalid
connection.user in cloudConnection
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11179/#review20690
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanna Santhanam
On May 15, 2013, 12:18 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11179/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 12:18 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> cloudConnection object should always have "user" and "passwd" attributes.
> And they are "None" while creating userAPIClient. As we already
> have "user" and "password" for mgmt server.
>
>
> This addresses bug CLOUDSTACK-2513.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py b5ff5bf
>
> Diff: https://reviews.apache.org/r/11179/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request: Fix CLOUDSTACK-2513 VPN tests refer to invalid
connection.user in cloudConnection
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11179/#review20687
-----------------------------------------------------------
Commit 4d0cea6626923a24a432c25eee8d93da4e4f504b in branch refs/heads/master from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d0cea6 ]
CLOUDSTACK-2513: VPN tests refer to invalid connection.user in cloudConnection
cloudConnection object should always have "user" and "passwd" attributes.
And they are "None" while creating userAPIClient. As we already
have "user" and "password" for mgmt server.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 15, 2013, 12:18 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11179/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 12:18 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> cloudConnection object should always have "user" and "passwd" attributes.
> And they are "None" while creating userAPIClient. As we already
> have "user" and "password" for mgmt server.
>
>
> This addresses bug CLOUDSTACK-2513.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py b5ff5bf
>
> Diff: https://reviews.apache.org/r/11179/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>