You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/28 23:26:33 UTC

[GitHub] [kafka] dielhennr commented on a change in pull request #11133: KAFKA-13140: KRaft brokers do not expose kafka.controller metrics

dielhennr commented on a change in pull request #11133:
URL: https://github.com/apache/kafka/pull/11133#discussion_r678717206



##########
File path: core/src/main/scala/kafka/server/KafkaRaftServer.scala
##########
@@ -100,6 +101,9 @@ class KafkaRaftServer(
       controllerQuorumVotersFuture
     ))
   } else {
+    // we need to register the various kafka.controller metrics
+    // for backwards compatibility with the ZooKeeper-based case
+    new QuorumControllerMetrics(KafkaYammerMetrics.defaultRegistry())

Review comment:
       It doesn't look like there is a way to register default metrics in the Yammer metrics library.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org