You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Syed Albiz <s....@gmail.com> on 2011/08/10 10:23:17 UTC
Review Request: HIVE-2354: Support automatic rebuilding of indexes when they
go stale
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
Review request for hive, John Sichi and Ning Zhang.
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cec0d46
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed
Re: Review Request: HIVE-2354: Support automatic rebuilding of indexes when
they go stale
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
(Updated 2011-08-19 20:20:22.217903)
Review request for hive, Yongqiang He, John Sichi, and Ning Zhang.
Changes
-------
Moves a bunch of the logic to update index timestamps into the AlterIndex DDLTask rather than the DDLSemanticAnalyzer, so that the timestamp is guaranteed to be updated *after* the base table is touched. This change is reflected in index_auto_update.q, as now we see that the check for index staleness in the SELECT passes and we use the index in index_auto_update.q as desired.
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 815f15a
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c031f40
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java c17891c
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 6f311c6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cb7a542
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java f0dfd00
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_stale.q.out 24900a1
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed
Re: Review Request: HIVE-2354: Support automatic rebuilding of indexes when
they go stale
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
(Updated 2011-08-19 19:20:00.521433)
Review request for hive, Yongqiang He, John Sichi, and Ning Zhang.
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 815f15a
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 6f311c6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cb7a542
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_stale.q.out 24900a1
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed
Re: Review Request: HIVE-2354: Support automatic rebuilding of indexes when
they go stale
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
(Updated 2011-08-19 19:10:10.969158)
Review request for hive, Yongqiang He, John Sichi, and Ning Zhang.
Changes
-------
Made the configuration variable false by default, and set it to true in the relevant tests
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 815f15a
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 6f311c6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cb7a542
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_stale.q.out 24900a1
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed
Re: Review Request: HIVE-2354: Support automatic rebuilding of indexes when
they go stale
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
(Updated 2011-08-18 10:28:36.489366)
Review request for hive, Yongqiang He, John Sichi, and Ning Zhang.
Changes
-------
updated testcases to include an EXPLAIN statement on the INSERT command to show the auto-update jobs
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 6f311c6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cec0d46
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed
Re: Review Request: HIVE-2354: Support automatic rebuilding of indexes when
they go stale
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
(Updated 2011-08-18 10:28:02.416294)
Review request for hive, John Sichi and Ning Zhang.
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 6f311c6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cec0d46
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed
Re: Review Request: HIVE-2354: Support automatic rebuilding of indexes when
they go stale
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1456/
-----------------------------------------------------------
(Updated 2011-08-15 22:01:14.270380)
Review request for hive, John Sichi and Ning Zhang.
Changes
-------
added a clause for LOAD DATA
Summary
-------
Chain a second set of tasks to the MoveTask for INSERT statements.
This addresses bug HIVE-2354.
https://issues.apache.org/jira/browse/HIVE-2354
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f
ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 6f311c6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cec0d46
ql/src/test/queries/clientpositive/index_auto_update.q PRE-CREATION
ql/src/test/results/clientpositive/index_auto_update.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1456/diff
Testing
-------
Added testcase "index_auto_update.q"
Thanks,
Syed