You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/17 09:19:07 UTC
[GitHub] [flink] WeiZhong94 opened a new pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
WeiZhong94 opened a new pull request #12921:
URL: https://github.com/apache/flink/pull/12921
## What is the purpose of the change
*This pull request makes the "input_types" parameter of the Python UDF/UDTF decorator optional.*
## Brief change log
- *Makes the "input_types" parameter of the Python UDF/UDTF decorator optional.*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12921:
URL: https://github.com/apache/flink/pull/12921#issuecomment-659996741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584",
"triggerID" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"triggerType" : "PUSH"
}, {
"hash" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d44810ab9e01a43a11fc662f5de16b93a9165143 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584)
* 95ee1425a0ee0b1f94234bc07e8b963ac720e6fa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12921:
URL: https://github.com/apache/flink/pull/12921#issuecomment-659996741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584",
"triggerID" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d44810ab9e01a43a11fc662f5de16b93a9165143 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12921:
URL: https://github.com/apache/flink/pull/12921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12921:
URL: https://github.com/apache/flink/pull/12921#issuecomment-659988987
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d44810ab9e01a43a11fc662f5de16b93a9165143 (Fri Jul 17 09:21:43 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18463).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12921:
URL: https://github.com/apache/flink/pull/12921#issuecomment-659996741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584",
"triggerID" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"triggerType" : "PUSH"
}, {
"hash" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4588",
"triggerID" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95ee1425a0ee0b1f94234bc07e8b963ac720e6fa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4588)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12921:
URL: https://github.com/apache/flink/pull/12921#issuecomment-659996741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584",
"triggerID" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"triggerType" : "PUSH"
}, {
"hash" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d44810ab9e01a43a11fc662f5de16b93a9165143 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584)
* 95ee1425a0ee0b1f94234bc07e8b963ac720e6fa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12921:
URL: https://github.com/apache/flink/pull/12921#issuecomment-659996741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d44810ab9e01a43a11fc662f5de16b93a9165143 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12921: [FLINK-18463][python] Make the "input_types" parameter of the Python UDF/UDTF decorator optional.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12921:
URL: https://github.com/apache/flink/pull/12921#issuecomment-659996741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584",
"triggerID" : "d44810ab9e01a43a11fc662f5de16b93a9165143",
"triggerType" : "PUSH"
}, {
"hash" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4588",
"triggerID" : "95ee1425a0ee0b1f94234bc07e8b963ac720e6fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d44810ab9e01a43a11fc662f5de16b93a9165143 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4584)
* 95ee1425a0ee0b1f94234bc07e8b963ac720e6fa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4588)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org