You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/20 21:39:48 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #7558:
Allowing editing scheduled queries
betodealmeida opened a new pull request #7558: Allowing editing scheduled queries
URL: https://github.com/apache/incubator-superset/pull/7558
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Allow editing `schedule_info` in saved queries that have it.
This is a bit messy because I didn't want to completely replace the current CRUD provided by FAB for saved queries (since I believe this is already in the works). Instead, I modified the template to have a button for editing the schedule, and it updates the information and submits the FAB form.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
![edit_schedule](https://user-images.githubusercontent.com/1534870/58053554-bbacd180-7b0c-11e9-8f14-7a7ae48e3fb3.gif)
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Tested locally. Also verified that regular, non-scheduled, queries work as before.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@mistercrunch @khtruong @DiggidyDave @datability-io
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org