[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3412: ARTEMIS-3074 Add ActiveMQServerControl#createBridge() method variant …

[GitBox <gi...@apache.org>]

jbertram commented on a change in pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#discussion_r562318018



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -3822,6 +3822,30 @@ public void createBridge(final String name,
       }
    }
 
+   @Override
+   public String createBridge(String bridgeConfigurationAsJson) throws Exception {

Review comment:
       This can return `void`. The only reason the `createQueue` JSON method returns a `String` is because the broker applies address settings to the queue on the fly to end up at the final configuration and that's something the client might like to know. In this case the broker just takes what it's given.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org