[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2856: [GOBBLIN-1011] adjust compaction flow to work with virtual partition

[GitBox <gi...@apache.org>]

htran1 commented on a change in pull request #2856: [GOBBLIN-1011] adjust compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r361040056
 
 

 ##########
 File path: gobblin-compaction/src/main/java/org/apache/gobblin/compaction/action/CompactionCompleteFileOperationAction.java
 ##########
 @@ -73,6 +74,11 @@ public CompactionCompleteFileOperationAction (State state, CompactionJobConfigur
    * Create a record count file containing the number of records that have been processed .
    */
   public void onCompactionJobComplete (FileSystemDataset dataset) throws IOException {
+    if (dataset instanceof SimpleFileSystemDataset
 
 Review comment:
   How about extending the FileSystemDataset interface with an isVirtual() method that defaults to false to avoid this specific instanceof and casting?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services