You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rajith Attapattu (JIRA)" <ji...@apache.org> on 2011/04/14 22:55:05 UTC
[jira] [Commented] (QPID-3207) AMQSession.java close() does not
close the consumers with the correct arguments
[ https://issues.apache.org/jira/browse/QPID-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020028#comment-13020028 ]
Rajith Attapattu commented on QPID-3207:
----------------------------------------
I have raised this issue on the qpid dev list and it seems nobody knows the reasons behind the original code.
http://mail-archives.apache.org/mod_mbox/qpid-dev/201104.mbox/%3CBANLkTinSwxvuL2vsobSwq2iz3HL8xtKKLg@mail.gmail.com%3E
I have changed the value of sendClose to "true" and so far the tests seems ok.
I am going to check in this change as it seems this is the right way to go.
> AMQSession.java close() does not close the consumers with the correct arguments
> -------------------------------------------------------------------------------
>
> Key: QPID-3207
> URL: https://issues.apache.org/jira/browse/QPID-3207
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: 0.11
>
>
> When the AMQSession.java close() is invoked it will in turn call the "private void closeConsumers(Throwable error) throws JMSException" method.
> In this method if the error is null then the consumer.close method is called with "sendClose=false".
> I wonder if this is the correct setting. I suspect the intended value is "true".
> The boolean value is used in determining if we should send a message-cancel or not.
> I am not sure why we are not going to send a message cancel in this case, as we haven't encountered a session error and the session is active.
> Note the AMQSession.java closes the session only after the consumers and producers are closed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org