[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6155: boards: Move -fno-strict-aliasing from Make.defs to Toolchain.defs

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #6155:
URL: https://github.com/apache/incubator-nuttx/pull/6155#discussion_r859479347


##########
arch/arm/src/arm/Toolchain.defs:
##########
@@ -51,20 +51,22 @@ endif
 #  CROSSDEV         The GNU toolchain triple (command prefix)
 #  ARCHCPUFLAGS     CPU-specific flags selecting the instruction set
 #                   FPU options, etc.
-#  MAXOPTIMIZATION  The maximum optimization level that results in
+#  ARCHOPTIMIZATION The maximum optimization level that results in

Review Comment:
   is it still the `The maximum optimization level`?



##########
Documentation/guides/cpp_cmake.rst:
##########
@@ -88,7 +88,7 @@ Creating the project
 
     include(cmake/stm32f4discovery.cmake)
 
-    set(AC_COMMON_FLAGS "${AC_COMMON_FLAGS} -Wall -Wshadow -Wundef -fno-strict-aliasing -Os")
+    set(AC_COMMON_FLAGS "${AC_COMMON_FLAGS} -Wall -Wshadow -Wundef -Os")

Review Comment:
   why removed from here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org