You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/31 17:17:13 UTC

[GitHub] [beam] aaltay commented on pull request #12407: Enable all Jenkins jobs triggering for committers

aaltay commented on pull request #12407:
URL: https://github.com/apache/beam/pull/12407#issuecomment-667237699


   > The [apache GitHub org](https://github.com/orgs/apache/people) consists of near 1000 "public" members. From my understanding, we only want to allow Beam committers (and not people related to other Apache projects).
   > 
   > Forcing everyone to make the connection public, also adds some level of complexity. It should be documented somewhere, everyone should be aware of it. Ideally, an automatic check should be performed (e.g. during the http://gitbox.apache.org/setup procedure ).
   > 
   > By the way, that level of complexity existed before [1]. It was just hidden and we were unaware of it ;)
   > 
   > [1] https://github.com/apache/infrastructure-puppet/blob/bca5fb9129f31799dc3a40ad121e8ab6e4bd1798/modules/gitbox/files/cgi-bin/relay.cgi#L91
   
   I think these are both good points. Change LGTM. Unless there is a objection I can merge this by end of today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org