[jira] Closed: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2115.
----------------------------------

    Resolution: Fixed

Thanks Stephen,

Well done, your patch is in trunk revision: 737200  

Only 2 other things to note.
* Please update before (re)doing a patch. I had already commited your fix on ShoppingCartServices.java in r737077
* While I was at it I replaced all cartLines.iterato() while loops by for loops 
** for that, I simply introduced private List<ShoppingCartItem> cartLines = FastList.newInstance(); 


> OrderServices.updateApprovedOrderItems should update OrderItemAttributes
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-2115
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2115
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: 2009-01-14_001_shoppingcart.patch, 2009-01-14_001_shoppingcart.patch, 2009-01-14_001_shoppingcart.patch
>
>
> I wanted updateApprovedOrderItems to be able to update any OrderItemAttributes there may be. added a new map (itemAttributesMap) to /applications/order/servicedef/services.xml#updateOrderItems the key value of the map should be in the form of
> attibuteName+ ":" + orderItemSeqId
> At the top of
> OrderServices.updateApprovedOrderItems(DispatchContext, Map) I create a new map with only the attribute names, later in the same method we repopulate the cartItem's OrderItemAttributes with any non-empty values. In saveUpdatedCartToOrder we call my modified ShoppingCart.makeAllOrderItemAttributes(String, int) I added the ability to return just empty , just filled or both empty and filled. 
> For previously filled attributes that are now empty I remove them from the database. for either new or chnaged ones they are just added to the toStore that already existed 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.