[Fwd: Re: Bug]

[Luke Blanshard <lu...@quiq.com>]

I sent this last Friday too.

-------- Original Message --------
From: Luke Blanshard <lu...@quiq.com>
Subject: Re: Bug
To: xerces-j-dev@xml.apache.org

Another bug, this one more of a typo.  Same system info as before:

Luke Blanshard wrote:

>   I found a bug in Xerces-J that shows up in at least 1.1.3 and 1.2.0.
> I'm running IBM's jdk 1.1.8 on Linux.

In DocumentImpl.java, the startDocument method, you test for whether the
document class being used is assignable to the fDocumentImpl field.  But
you have the test backwards.  The test as implemented is:

                if (docClass.isAssignableFrom(defaultDocClass)) {
                    fDocumentImpl = (DocumentImpl)fDocument;
                    fDocumentImpl.setErrorChecking(false);
                }

but it should be:

                if (defaultDocClass.isAssignableFrom(docClass)) {
                    fDocumentImpl = (DocumentImpl)fDocument;
                    fDocumentImpl.setErrorChecking(false);
                }


Cheers,
Luke