You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/09 17:51:15 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #11192: Minor: rename namedTopology is taks ID to topologyName
wcarlson5 opened a new pull request #11192:
URL: https://github.com/apache/kafka/pull/11192
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] izzyacademy commented on a change in pull request #11192: KAFKA-12779: rename namedTopology in TaskId to topologyName
Posted by GitBox <gi...@apache.org>.
izzyacademy commented on a change in pull request #11192:
URL: https://github.com/apache/kafka/pull/11192#discussion_r685437675
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -76,13 +76,13 @@ public int partition() {
/**
* Experimental feature -- will return null
*/
- public String namedTopology() {
- return namedTopology;
+ public String topologyName() {
+ return topologyName;
Review comment:
I am just curious why this was not a getter (ie getTopologyName()) instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #11192: KAFKA-12779: rename namedTopology in TaskId to topologyName
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #11192:
URL: https://github.com/apache/kafka/pull/11192#issuecomment-895596665
Merged to `trunk`. Did not cherry-pick cleanly to 3.0. Follow up PR for 3.0: https://github.com/apache/kafka/pull/11194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] izzyacademy commented on pull request #11192: KAFKA-12779: rename namedTopology in TaskId to topologyName
Posted by GitBox <gi...@apache.org>.
izzyacademy commented on pull request #11192:
URL: https://github.com/apache/kafka/pull/11192#issuecomment-895512739
> > Overall changes look straightforward but I just had a question regarding why one of the methods on TaskId was not a real getter with the get* prefix.
>
> @izzyacademy It's custom in the whole Kafka code base, that we don't use the `getXxx` but `xxx()` for all getter methods.
Thanks for the clarification @mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #11192: KAFKA-12779: rename namedTopology in TaskId to topologyName
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #11192:
URL: https://github.com/apache/kafka/pull/11192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #11192: MINOR: rename namedTopology is taks ID to topologyName
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #11192:
URL: https://github.com/apache/kafka/pull/11192#issuecomment-895435833
Approved for 3.0. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on a change in pull request #11192: KAFKA-12779: rename namedTopology in TaskId to topologyName
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on a change in pull request #11192:
URL: https://github.com/apache/kafka/pull/11192#discussion_r685443125
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -76,13 +76,13 @@ public int partition() {
/**
* Experimental feature -- will return null
*/
- public String namedTopology() {
- return namedTopology;
+ public String topologyName() {
+ return topologyName;
Review comment:
It's by convention I think. If you look at all of the other "getters" none of them are prefixed with get either. I.e. partition() or subtopology()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #11192: KAFKA-12779: rename namedTopology in TaskId to topologyName
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #11192:
URL: https://github.com/apache/kafka/pull/11192#issuecomment-895497662
> Overall changes look straightforward but I just had a question regarding why one of the methods on TaskId was not a real getter with the get* prefix.
@izzyacademy It's custom in the whole Kafka code base, that we don't use the `getXxx` but `xxx()` for all getter methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org