[GitHub] [qpid-dispatch] grs commented on a change in pull request #897: DISPATCH-1815: Send PING frame every 4 seconds on an egress connection

[GitBox <gi...@apache.org>]

grs commented on a change in pull request #897:
URL: https://github.com/apache/qpid-dispatch/pull/897#discussion_r512725180



##########
File path: src/adaptors/http2/http2_adaptor.h
##########
@@ -138,6 +141,7 @@ struct qdr_http2_connection_t {
     bool                      ingress;
     bool                      timer_scheduled;
     bool                      client_magic_sent;
+    time_t                    prev_ping; // Time the previous PING frame was sent on egress connection.

Review comment:
       Strictly this could be the last time for any write to the socket, not just a ping. The time could then be updated on every write.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org