You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/04/22 14:10:45 UTC

[GitHub] [parquet-mr] dossett commented on pull request #959: PARQUET-2126: Make cached (de)compressors thread-safe

dossett commented on PR #959:
URL: https://github.com/apache/parquet-mr/pull/959#issuecomment-1106556192

   Seems good to me (non-binding!).  Revisiting whether or not the caching strategy make sense might be worthwhile, but that shouldn't stop this fix. 
   
   Small comment: I would remove most of the references to the JIRA ticket as well as descriptions of the old behavior.  I think the comment that describes the new behavior and why it might be unintuitive with a reference to the JIRA makes sense though.  I'll defer to others in the project (again, I'm not a committer) if there are existing standards for this though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org