You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/25 20:30:55 UTC

[GitHub] [beam] damccorm commented on pull request #22897: Add map state in the Go Sdk

damccorm commented on PR #22897:
URL: https://github.com/apache/beam/pull/22897#issuecomment-1227730403

   R: @riteshghorse 
   
   FWIW, this is a larger PR because I thought it would make more sense as a cohesive change and because its so similar to the other changes. With that said, as you review I'd probably recommend thinking about it in 3 pieces (and reviewing it in that order):
   
   1. Extending existing plumbing to support keyed state (both translate.go's)
   2. Execution side stuff (statemgr.go + userstate.go)
   3. User side stuff (state.go + fn.go).
   4. Misc interface + tests (everything else)
   
   I'd probably recommend reading the PR in that order.
   
   Generally, the reason this PR is a little bigger is because we're using new protos for multimap state instead of the ones we've been using for bag state.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org