[GitHub] [iotdb] MrQuansy commented on a change in pull request #3879: [IOTDB-1484]Auto create schema functionality with e2e testing in cluster

[GitBox <gi...@apache.org>]

MrQuansy commented on a change in pull request #3879:
URL: https://github.com/apache/iotdb/pull/3879#discussion_r706855749



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/DataGroupMember.java
##########
@@ -816,6 +828,22 @@ private boolean createTimeseriesForFailedInsertion(InsertPlan plan)
       }
     }
 
+    if (plan instanceof InsertRowsPlan) {
+      for (InsertRowPlan insertPlan : ((InsertRowsPlan) plan).getInsertRowPlanList()) {
+        if (insertPlan.getFailedMeasurements() != null) {
+          insertPlan.getPlanFromFailed();
+        }
+      }
+    }
+
+    if (plan instanceof InsertRowsOfOneDevicePlan) {
+      for (InsertRowPlan insertPlan : ((InsertRowsOfOneDevicePlan) plan).getRowPlans()) {
+        if (insertPlan.getFailedMeasurements() != null) {
+          insertPlan.getPlanFromFailed();

Review comment:
       The method getPlanFromFailed can only get failed measurements without successful ones, so fewer time series will be processed afterwards.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org