You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/09 15:58:28 UTC

[GitHub] [flink] 1u0 commented on issue #9586: [hotfix] fix typos

1u0 commented on issue #9586: [hotfix] fix typos
URL: https://github.com/apache/flink/pull/9586#issuecomment-529547122
 
 
   Hi @KangZhiDong,
   Thank you for contribution!
   
   I'm `+1` for `a unique` fix.
   
   For all the rest changes (`an http*`, `an sql*`, `an ssl*`), I find it questionable. Could you please revert them?
   
   More specifically, if your changes would be applied, someone else can open a new PR that would change them to use the old article and those people would be right on their own way.
   Also, you can compare word pair frequencies in some online tools and those frequencies won't be in your favor.
   
   General recommendation: the commit message can be more specific, for example:
   `[hotfix][docs] Adjust English articles for ...`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services