You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by johnament <gi...@git.apache.org> on 2016/08/01 02:25:54 UTC
[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
GitHub user johnament opened a pull request:
https://github.com/apache/activemq-artemis/pull/691
ARTEMIS-659 Remove unneeded CDI dependency. Switch to geronimo atinj\u2026
\u2026ect JAR in all uses.
It turned out the client wasn't even using the dependency and the JARs were duplicated. So more than anything this is clean up of unnecessary dependencies.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnament/activemq-artemis ARTEMIS-659
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/691.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #691
----
commit 05a41eb8f2ad32c5932a60e590d35bd855302bf5
Author: John D. Ament <jo...@apache.org>
Date: 2016-08-01T02:24:02Z
ARTEMIS-659 Remove unneeded CDI dependency. Switch to geronimo atinject JAR in all uses.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/691#discussion_r73035248
--- Diff: pom.xml ---
@@ -349,16 +349,9 @@
<!-- Required for: JMS Injection -->
<dependency>
- <groupId>javax.enterprise</groupId>
- <artifactId>cdi-api</artifactId>
- <version>1.2</version>
- <!-- License: Apache 2.0 -->
- </dependency>
- <dependency>
- <groupId>javax.inject</groupId>
- <artifactId>javax.inject</artifactId>
- <version>1</version>
- <!-- License: Apache 2.0 -->
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-atinject_1.0_spec</artifactId>
+ <version>1.0</version>
--- End diff --
JMS 2 defines injection points. The way it ended up being phrased, its the app server's realm of responsibility to provide those injection points. OpenMQ for example provides a CDI module. HornetQ/Artemis do not as of now. Wildfly's JMS integration module takes care of this, similarly TomEE does the same.
It turns out this is needed for the link you emailed earlier - the integration test for Karaf/OSGi.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #691: ARTEMIS-659 Remove unneeded CDI dependency. Swi...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/691
I just opened #694. And I'm running a few tests on it. It seems good so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #691: ARTEMIS-659 Remove unneeded CDI dependency. Swi...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/691
BTW: keep this one open for now. Let me finish my tests first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/691#discussion_r73031897
--- Diff: pom.xml ---
@@ -349,16 +349,9 @@
<!-- Required for: JMS Injection -->
<dependency>
- <groupId>javax.enterprise</groupId>
- <artifactId>cdi-api</artifactId>
- <version>1.2</version>
- <!-- License: Apache 2.0 -->
- </dependency>
- <dependency>
- <groupId>javax.inject</groupId>
- <artifactId>javax.inject</artifactId>
- <version>1</version>
- <!-- License: Apache 2.0 -->
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-atinject_1.0_spec</artifactId>
+ <version>1.0</version>
--- End diff --
why not remove it then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/691#discussion_r73035839
--- Diff: pom.xml ---
@@ -349,16 +349,9 @@
<!-- Required for: JMS Injection -->
<dependency>
- <groupId>javax.enterprise</groupId>
- <artifactId>cdi-api</artifactId>
- <version>1.2</version>
- <!-- License: Apache 2.0 -->
- </dependency>
- <dependency>
- <groupId>javax.inject</groupId>
- <artifactId>javax.inject</artifactId>
- <version>1</version>
- <!-- License: Apache 2.0 -->
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-atinject_1.0_spec</artifactId>
+ <version>1.0</version>
--- End diff --
That test is very fragile regarding dependencies. if you change any dependency you may have to update it.. maybe that's all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #691: ARTEMIS-659 Remove unneeded CDI dependency. Swi...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/691
@johnament thanks for pointing this out. I only pushed it because you pointed this was not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
Posted by johnament <gi...@git.apache.org>.
Github user johnament closed the pull request at:
https://github.com/apache/activemq-artemis/pull/691
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #691: ARTEMIS-659 Remove unneeded CDI dependency. Swi...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/691
Closing out since Clebert pushed his own version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/691#discussion_r73031975
--- Diff: pom.xml ---
@@ -349,16 +349,9 @@
<!-- Required for: JMS Injection -->
<dependency>
- <groupId>javax.enterprise</groupId>
- <artifactId>cdi-api</artifactId>
- <version>1.2</version>
- <!-- License: Apache 2.0 -->
- </dependency>
- <dependency>
- <groupId>javax.inject</groupId>
- <artifactId>javax.inject</artifactId>
- <version>1</version>
- <!-- License: Apache 2.0 -->
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-atinject_1.0_spec</artifactId>
+ <version>1.0</version>
--- End diff --
I always thought this was needed for JMS2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/691#discussion_r72918082
--- Diff: pom.xml ---
@@ -349,16 +349,9 @@
<!-- Required for: JMS Injection -->
<dependency>
- <groupId>javax.enterprise</groupId>
- <artifactId>cdi-api</artifactId>
- <version>1.2</version>
- <!-- License: Apache 2.0 -->
- </dependency>
- <dependency>
- <groupId>javax.inject</groupId>
- <artifactId>javax.inject</artifactId>
- <version>1</version>
- <!-- License: Apache 2.0 -->
+ <groupId>org.apache.geronimo.specs</groupId>
+ <artifactId>geronimo-atinject_1.0_spec</artifactId>
+ <version>1.0</version>
--- End diff --
This may not even be needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---