You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/25 04:00:00 UTC
[jira] [Commented] (KYLIN-4281) Precisely set the data type of tuple expression

    [ https://issues.apache.org/jira/browse/KYLIN-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115673#comment-17115673 ] 

ASF GitHub Bot commented on KYLIN-4281:
---------------------------------------

coveralls edited a comment on pull request #1144:
URL: https://github.com/apache/kylin/pull/1144#issuecomment-595125477


   ## Pull Request Test Coverage Report for [Build 5941](https://coveralls.io/builds/31004475)
   
   * **233** of **898**   **(25.95%)**  changed or added relevant lines in **57** files are covered.
   * **18** unchanged lines in **11** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **28.445%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-cube/src/main/java/org/apache/kylin/gridtable/GTFunctionScanner.java](https://coveralls.io/builds/31004475/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fgridtable%2FGTFunctionScanner.java#L54) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/MeasureType.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2FMeasureType.java#L82) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapSerializer.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapSerializer.java#L42) | 1 | 2 | 50.0%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/expression/ColumnTupleExpression.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fexpression%2FColumnTupleExpression.java#L44) | 3 | 4 | 75.0%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/expression/NoneTupleExpression.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fexpression%2FNoneTupleExpression.java#L30) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/metadata/expression/RexCallTupleExpression.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fexpression%2FRexCallTupleExpression.java#L31) | 0 | 1 | 0.0%
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeTupleConverter.java](https://coveralls.io/builds/31004475/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FCubeTupleConverter.java#L119) | 0 | 1 | 0.0%
   | [query/src/main/java/org/apache/kylin/query/relnode/OLAPUnionRel.java](https://coveralls.io/builds/31004475/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPUnionRel.java#L114) | 0 | 1 | 0.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/31004475/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L300) | 0 | 2 | 0.0%
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeSegment.java](https://coveralls.io/builds/31004475/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeSegment.java#L360) | 0 | 2 | 0.0%
   <!-- | **Total:** | **233** | **898** | **25.95%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java](https://coveralls.io/builds/31004475/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeDescManager.java#L302) | 1 | 38.57% |
   | [core-cube/src/main/java/org/apache/kylin/gridtable/GTUtil.java](https://coveralls.io/builds/31004475/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fgridtable%2FGTUtil.java#L148) | 1 | 1.34% |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/expression/RexCallTupleExpression.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fexpression%2FRexCallTupleExpression.java#L32) | 1 | 0% |
   | [query/src/main/java/org/apache/kylin/query/relnode/OLAPContext.java](https://coveralls.io/builds/31004475/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPContext.java#L196) | 1 | 0% |
   | [query/src/main/java/org/apache/kylin/query/relnode/OLAPProjectRel.java](https://coveralls.io/builds/31004475/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPProjectRel.java#L205) | 1 | 0% |
   | [query/src/main/java/org/apache/kylin/query/relnode/OLAPUnionRel.java](https://coveralls.io/builds/31004475/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Frelnode%2FOLAPUnionRel.java#L115) | 1 | 0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/gridtable/ScanRangePlannerBase.java](https://coveralls.io/builds/31004475/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fgridtable%2FScanRangePlannerBase.java#L184) | 2 | 0% |
   | [core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRequest.java](https://coveralls.io/builds/31004475/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fgridtable%2FGTScanRequest.java#L244) | 2 | 29.92% |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/expression/BinaryTupleExpression.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fexpression%2FBinaryTupleExpression.java#L36) | 2 | 68.24% |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/DynamicFunctionDesc.java](https://coveralls.io/builds/31004475/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FDynamicFunctionDesc.java#L27) | 2 | 0% |
   <!-- | **Total:** | **18** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/31004475/badge)](https://coveralls.io/builds/31004475) |
   | :-- | --: |
   | Change from base [Build 5937](https://coveralls.io/builds/30987930): |  0.01% |
   | Covered Lines: | 25646 |
   | Relevant Lines: | 90159 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Precisely set the data type of tuple expression
> -----------------------------------------------
>
>                 Key: KYLIN-4281
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4281
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Zhong Yanghong
>            Assignee: Zhong Yanghong
>            Priority: Major
>             Fix For: v3.1.0
>
>
> Previously to simplify the calculating of sum(case when), all of the binary calculation is based on BigDecimal, which is not good for all, especially when dealing with count(distinct case when), whose inner data type may be hll or bitmap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)