You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/04/16 00:50:34 UTC

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15744


Change subject: mini-cluster: exclude libpcre for license check
......................................................................

mini-cluster: exclude libpcre for license check

While building mini cluster binaries on centos7, I saw error message
'unknown license: lib/libpcre.so.1' during license check on artifact.
By running lddtree on the binary, I found out libpcre is introduced
as transitive dependency

libcurl.so.4 => /root/kudu/thirdparty/installed/uninstrumented/lib/libcurl.so.4
        libk5crypto.so.3 => /lib64/libk5crypto.so.3
            libkrb5support.so.0 => /lib64/libkrb5support.so.0
                libselinux.so.1 => /lib64/libselinux.so.1
                    libpcre.so.1 => /lib64/libpcre.so.1

This patch excludes 'libpcre' for license check to account for licensing
information only relevant to the binary artifacts.

Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Reviewed-on: http://gerrit.cloudera.org:8080/15738
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit cd95fef01d19674a8c43784bc4f3cd0ef1f4b5ac)
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/15744/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Gerrit-Change-Number: 15744
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15744 )

Change subject: mini-cluster: exclude libpcre for license check
......................................................................

mini-cluster: exclude libpcre for license check

While building mini cluster binaries on centos7, I saw error message
'unknown license: lib/libpcre.so.1' during license check on artifact.
By running lddtree on the binary, I found out libpcre is introduced
as transitive dependency

libcurl.so.4 => /root/kudu/thirdparty/installed/uninstrumented/lib/libcurl.so.4
        libk5crypto.so.3 => /lib64/libk5crypto.so.3
            libkrb5support.so.0 => /lib64/libkrb5support.so.0
                libselinux.so.1 => /lib64/libselinux.so.1
                    libpcre.so.1 => /lib64/libpcre.so.1

This patch excludes 'libpcre' for license check to account for licensing
information only relevant to the binary artifacts.

Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Reviewed-on: http://gerrit.cloudera.org:8080/15738
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit cd95fef01d19674a8c43784bc4f3cd0ef1f4b5ac)
Reviewed-on: http://gerrit.cloudera.org:8080/15744
Tested-by: Hao Hao <ha...@cloudera.com>
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Hao Hao: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Gerrit-Change-Number: 15744
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15744 )

Change subject: mini-cluster: exclude libpcre for license check
......................................................................


Patch Set 1:

Unrelated flaky test.


-- 
To view, visit http://gerrit.cloudera.org:8080/15744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Gerrit-Change-Number: 15744
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 16 Apr 2020 04:16:55 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15744 )

Change subject: mini-cluster: exclude libpcre for license check
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Gerrit-Change-Number: 15744
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 16 Apr 2020 04:17:05 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15744 )

Change subject: mini-cluster: exclude libpcre for license check
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Gerrit-Change-Number: 15744
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 16 Apr 2020 00:54:02 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.12.x) mini-cluster: exclude libpcre for license check

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.

Change subject: mini-cluster: exclude libpcre for license check
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
Gerrit-Change-Number: 15744
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)