You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Franklin Hu <fr...@fb.com> on 2011/08/03 01:28:01 UTC

Re: Review Request: HIVE-2305 UNION ALL on columns of different types throws exception

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1223/
-----------------------------------------------------------

(Updated 2011-08-02 23:28:01.105364)


Review request for hive, Yongqiang He, namit jain, and Siying Dong.


Summary
-------

UNION ALL on columns of different types is semantically allowed but throws a runtime exception due to bugs in getting the correct object inspector after the parent MR input file is change and in setting the TypeInfo for the union row schema.


This addresses bug hive-2305.
    https://issues.apache.org/jira/browse/hive-2305


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnInfo.java 1151937 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1151937 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 1151937 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 1151937 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1151937 
  trunk/ql/src/test/queries/clientpositive/union24.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/union24.q.out PRE-CREATION 
  trunk/ql/src/test/results/compiler/plan/union.q.xml 1151937 

Diff: https://reviews.apache.org/r/1223/diff


Testing
-------

unit tests pass


Thanks,

Franklin