You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/17 01:54:38 UTC
[GitHub] [geode] DonalEvans opened a new pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
DonalEvans opened a new pull request #5862:
URL: https://github.com/apache/geode/pull/5862
- OperationExecutors.MAX_THREADS new default is 300
- ClusterOperationExecutors.MAX_PR_THREADS new default is
Math.max(Runtime.getRuntime().availableProcessors() * 32, 200))
- Removed unit test case for setting system property, since it cannot be
cleared afterwards without unloading the class
Authored-by: Donal Evans <do...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] agingade commented on a change in pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
Posted by GitBox <gi...@apache.org>.
agingade commented on a change in pull request #5862:
URL: https://github.com/apache/geode/pull/5862#discussion_r545321822
##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/OperationExecutors.java
##########
@@ -26,7 +26,7 @@
*/
public interface OperationExecutors {
int MAX_THREADS =
- Integer.getInteger("DistributionManager.MAX_THREADS", 100);
+ Integer.getInteger("DistributionManager.MAX_THREADS", 300);
Review comment:
There is another ticket to address this issue: GEODE-8357
This change has an impact on overall system requirement and performance; it will be nice to send a proposal to developer community. This helps to get feedback from engineers who had encountered issue with this setting and suggested the recommendation to the users (support teams); there was conversation about changing this to big number like 1000.
It will be good to come up with a right number based on previous experience in setting this number.
We also need to think about setting the system properties automatically; some kind of auto-tuning service in the product that will adopt/changes the value based on the resource availability and the system load.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #5862:
URL: https://github.com/apache/geode/pull/5862#discussion_r545237155
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/properties.html
##########
@@ -383,7 +383,7 @@ <h1>Properties, in Alphabetical Order</h1>
<dd>
<em>Public:</em> false
<p>
-<em>Integer</em> (default is 1)
+<em>Integer</em> (default is 200)
Review comment:
Thanks for pointing this out, I'll update the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #5862:
URL: https://github.com/apache/geode/pull/5862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag commented on a change in pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
Posted by GitBox <gi...@apache.org>.
nabarunnag commented on a change in pull request #5862:
URL: https://github.com/apache/geode/pull/5862#discussion_r548160075
##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/OperationExecutors.java
##########
@@ -26,7 +26,7 @@
*/
public interface OperationExecutors {
int MAX_THREADS =
- Integer.getInteger("DistributionManager.MAX_THREADS", 100);
+ Integer.getInteger("DistributionManager.MAX_THREADS", 300);
Review comment:
@agingade we created this PR after receiving feedback from customers and support. This is one of the requested features from the field and these are the numbers we have received from support.
We are also aligning these numbers with MAX_FE_THREADS, which was changed to cpu*32 to tune the internal tests.
This can be a temporary band-aid till we start on GEODE-8357, which has more extensive changes and we can involve the community feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #5862:
URL: https://github.com/apache/geode/pull/5862#discussion_r552148174
##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/OperationExecutors.java
##########
@@ -26,7 +26,7 @@
*/
public interface OperationExecutors {
int MAX_THREADS =
- Integer.getInteger("DistributionManager.MAX_THREADS", 100);
+ Integer.getInteger("DistributionManager.MAX_THREADS", 300);
Review comment:
Having talked to some other people with more hands-on experience with hitting the limit currently set by `MAX_THREADS`, a value of 1000 was decided to be more appropriate. The PR has been updated to reflect this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jhutchison commented on a change in pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
Posted by GitBox <gi...@apache.org>.
jhutchison commented on a change in pull request #5862:
URL: https://github.com/apache/geode/pull/5862#discussion_r545231177
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/properties.html
##########
@@ -383,7 +383,7 @@ <h1>Properties, in Alphabetical Order</h1>
<dd>
<em>Public:</em> false
<p>
-<em>Integer</em> (default is 1)
+<em>Integer</em> (default is 200)
Review comment:
not sure if I'm missing something, but it looks like default will be 200, if the machine has less than 6 cores, other wise the default is num processors * 32. Not sure how significant this info is to our users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #5862: GEODE-8799: Increase defaults for OperationExecutors.MAX_THREADS and ClusterOperationExecutors.MAX_PR_THREADS
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #5862:
URL: https://github.com/apache/geode/pull/5862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org