You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/04/06 21:45:49 UTC
[Impala-ASF-CR] IMPALA-11230: Add test for crash in partitioned Top-N codegen code
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18389
Change subject: IMPALA-11230: Add test for crash in partitioned Top-N codegen code
......................................................................
IMPALA-11230: Add test for crash in partitioned Top-N codegen code
User workloads hit a crash for certain queries that
use partitioned Top-N operators. The crash occurred
only when codegen is enabled. After investigation,
the crash was due to a nullptr being passed into
TupleRowComparator::Compare(). The issue was fixed
as part of IMPALA-10961.
This adds a test case with a SQL statement that
triggers a crash if IMPALA-10961 is not present.
Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
---
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns-tpcds-partitioned-topn.test
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/18389/1
--
To view, visit http://gerrit.cloudera.org:8080/18389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
Gerrit-Change-Number: 18389
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11230: Add test for crash in partitioned Top-N codegen code
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18389 )
Change subject: IMPALA-11230: Add test for crash in partitioned Top-N codegen code
......................................................................
IMPALA-11230: Add test for crash in partitioned Top-N codegen code
User workloads hit a crash for certain queries that
use partitioned Top-N operators. The crash occurred
only when codegen is enabled. After investigation,
the crash was due to a nullptr being passed into
TupleRowComparator::Compare(). The issue was fixed
as part of IMPALA-10961.
This adds a test case with a SQL statement that
triggers a crash if IMPALA-10961 is not present.
Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
Reviewed-on: http://gerrit.cloudera.org:8080/18389
Reviewed-by: Aman Sinha <am...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns-tpcds-partitioned-topn.test
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Aman Sinha: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
Gerrit-Change-Number: 18389
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11230: Add test for crash in partitioned Top-N codegen code
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18389 )
Change subject: IMPALA-11230: Add test for crash in partitioned Top-N codegen code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
Gerrit-Change-Number: 18389
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Apr 2022 23:46:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11230: Add test for crash in partitioned Top-N codegen code
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18389 )
Change subject: IMPALA-11230: Add test for crash in partitioned Top-N codegen code
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8029/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
Gerrit-Change-Number: 18389
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Apr 2022 01:13:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11230: Add test for crash in partitioned Top-N codegen code
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18389 )
Change subject: IMPALA-11230: Add test for crash in partitioned Top-N codegen code
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
Gerrit-Change-Number: 18389
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Apr 2022 05:39:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11230: Add test for crash in partitioned Top-N codegen code
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18389 )
Change subject: IMPALA-11230: Add test for crash in partitioned Top-N codegen code
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10409/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6909ef660b01ad3d301273deb8a8c31120445f79
Gerrit-Change-Number: 18389
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Apr 2022 22:05:54 +0000
Gerrit-HasComments: No