You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (JIRA)" <ji...@apache.org> on 2012/07/31 03:29:33 UTC
[jira] [Created] (FLUME-1408) When a Throwable will not be handled
or logged, it should be logged
Brock Noland created FLUME-1408:
-----------------------------------
Summary: When a Throwable will not be handled or logged, it should be logged
Key: FLUME-1408
URL: https://issues.apache.org/jira/browse/FLUME-1408
Project: Flume
Issue Type: Improvement
Reporter: Brock Noland
Priority: Minor
In FLUME-1246 we added a log entry for NoClassDef to AbstractFileConfigurationProvider, however since we are ScheduledExecutorService any other Error which is thrown will also be hidden. As such in this case we should catch Throwable and log.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLUME-1408) ScheduledExecutorService does not
log uncaught Throwables, we should log them
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hari Shreedharan resolved FLUME-1408.
-------------------------------------
Resolution: Fixed
Fix Version/s: v1.3.0
Assignee: Brock Noland
Patch committed. Thanks Brock!
> ScheduledExecutorService does not log uncaught Throwables, we should log them
> -----------------------------------------------------------------------------
>
> Key: FLUME-1408
> URL: https://issues.apache.org/jira/browse/FLUME-1408
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Priority: Minor
> Fix For: v1.3.0
>
> Attachments: FLUME-1408-1.patch, FLUME-1408-1.patch
>
>
> In FLUME-1246 we added a log entry for NoClassDef to AbstractFileConfigurationProvider, however since we are ScheduledExecutorService any other Error which is thrown will also be hidden. As such in this case we should catch Throwable and log.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1408) When a Throwable will not be handled
or logged, it should be logged
Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1408:
--------------------------------
Attachment: FLUME-1408-1.patch
Attached fixes all know instances.
> When a Throwable will not be handled or logged, it should be logged
> -------------------------------------------------------------------
>
> Key: FLUME-1408
> URL: https://issues.apache.org/jira/browse/FLUME-1408
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Attachments: FLUME-1408-1.patch
>
>
> In FLUME-1246 we added a log entry for NoClassDef to AbstractFileConfigurationProvider, however since we are ScheduledExecutorService any other Error which is thrown will also be hidden. As such in this case we should catch Throwable and log.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1408) ScheduledExecutorService does not log
uncaught Throwables, we should log them
Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1408:
--------------------------------
Summary: ScheduledExecutorService does not log uncaught Throwables, we should log them (was: When a Throwable will not be handled or logged, it should be logged)
> ScheduledExecutorService does not log uncaught Throwables, we should log them
> -----------------------------------------------------------------------------
>
> Key: FLUME-1408
> URL: https://issues.apache.org/jira/browse/FLUME-1408
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Attachments: FLUME-1408-1.patch
>
>
> In FLUME-1246 we added a log entry for NoClassDef to AbstractFileConfigurationProvider, however since we are ScheduledExecutorService any other Error which is thrown will also be hidden. As such in this case we should catch Throwable and log.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1408) ScheduledExecutorService does not log
uncaught Throwables, we should log them
Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1408:
--------------------------------
Attachment: FLUME-1408-1.patch
Updated patch (removed white space)
> ScheduledExecutorService does not log uncaught Throwables, we should log them
> -----------------------------------------------------------------------------
>
> Key: FLUME-1408
> URL: https://issues.apache.org/jira/browse/FLUME-1408
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Attachments: FLUME-1408-1.patch, FLUME-1408-1.patch
>
>
> In FLUME-1246 we added a log entry for NoClassDef to AbstractFileConfigurationProvider, however since we are ScheduledExecutorService any other Error which is thrown will also be hidden. As such in this case we should catch Throwable and log.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira